AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tst_QNetworkReply: Avoid race in ioGetFromHttpWithAuth

Browse Source 
Our authentication code is race-y by design:
1. When two requests are fired off and queued at the same time in the
same QHttpNetworkConnection then if one of them encounters
"authentication required" then it will copy whatever credentials it got
to all the other channels in the connection. This is likely what the
first part of the test is testing.
2. If a later request is fired off and it includes credentials in the
url then the newly included credentials should be used instead of the
cached ones.

The race here can occurr when one socket either takes too long to
connect or the connected signal is not received early enough. Then the
first socket is used for both requests and then we can hit case #2 when
the url contains credentials.

Pick-to: 5.15
Change-Id: I646a5378d8c1256b2de98b51912953df29f68cb2
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
This commit is contained in:
Mårten Nordheim 2020-09-10 16:30:36 +02:00
parent 7dd99cd488
commit 5a47939d5c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp
View File

@ -3499,7 +3499,11 @@ void tst_QNetworkReply::ioGetFromHttpWithAuth()
QNetworkRequest request(url);
{
QNetworkReplyPtr reply1(manager.get(request));
QNetworkReplyPtr reply2(manager.get(request));
QUrl copy = url;
copy.setUserName(QString());
copy.setPassword(QString());
QNetworkRequest request2(copy);
QNetworkReplyPtr reply2(manager.get(request2));
DataReader reader1(reply1);
DataReader reader2(reply2);
QSignalSpy finishedspy(reply1.data(), SIGNAL(finished()));