AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QPixmapFilter: some cleanup

Browse Source 
Use unique_ptr instead of plain array. No need to call 'delete'.

Change-Id: Ia77f4f209b1fd83391428d8b82b7acbba48781b9
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Anton Kudryavtsev 2018-10-12 12:43:22 +03:00 committed by Anton Kudryavtsev
parent eb4d39ada0
commit 5ab9451846
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/widgets/effects/qpixmapfilter.cpp
View File

@ -54,6 +54,8 @@
#include "private/qmemrotate_p.h"
#include "private/qdrawhelper_p.h"
#include <memory>
QT_BEGIN_NAMESPACE
class QPixmapFilterPrivate : public QObjectPrivate
@ -319,7 +321,7 @@ static void convolute(
const QImage processImage = (srcImage.format() != QImage::Format_ARGB32_Premultiplied ) ? srcImage.convertToFormat(QImage::Format_ARGB32_Premultiplied) : srcImage;
// TODO: support also other formats directly without copying
int *fixedKernel = new int[kernelWidth*kernelHeight];
std::unique_ptr<int[]> fixedKernel(new int[kernelWidth * kernelHeight]);
for(int i = 0; i < kernelWidth*kernelHeight; i++)
{
fixedKernel[i] = (int)(65536 * kernel[i]);
@ -403,7 +405,6 @@ static void convolute(
}
yk++;
}
delete[] fixedKernel;
}
/*!