AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change misleading error message in QDBusReply

Browse Source 
"no signature" is misleading and even led me to re-check the code to see
if it meant that the reply failed and no signature could be obtained.
Saying that the signature was obtained but is empty is better.

Change-Id: I1381cf53b334798125d36db0934105d15b63b84f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@theqtcompany.com>
This commit is contained in:
Thiago Macieira 2014-12-02 15:53:02 -08:00
parent 0f88c5c1b9
commit 5d8baf9056
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dbus/qdbusreply.cpp
View File

@ -219,7 +219,7 @@ void qDBusReplyFill(const QDBusMessage &reply, QDBusError &error, QVariant &data
// error // error
if (receivedSignature.isEmpty()) if (receivedSignature.isEmpty())
receivedSignature = "no signature"; receivedSignature = "<empty signature>";
QString errorMsg; QString errorMsg;
if (receivedType) { if (receivedType) {
errorMsg = QString::fromLatin1("Unexpected reply signature: got \"%1\" (%4), " errorMsg = QString::fromLatin1("Unexpected reply signature: got \"%1\" (%4), "