AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QHashFunctions: test for hash equality of null and empty string types

Browse Source 
In Qt, null QStrings compare equal to empty ones, so add an explicit
check that the corresponding hash values are identical, too.

Ditto for QByteArray.

Change-Id: I190fc95a765305928d9b6b0e4955433865b6b247
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Marc Mutz 2016-07-11 12:11:14 +02:00
parent 7c279d779b
commit 6a7bae9a26
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/auto/corelib/tools/qhashfunctions/tst_qhashfunctions.cpp
View File

@ -45,6 +45,8 @@ class tst_QHashFunctions : public QObject
Q_OBJECT Q_OBJECT
private Q_SLOTS: private Q_SLOTS:
void qhash(); void qhash();
void qhash_of_empty_and_null_qstring();
void qhash_of_empty_and_null_qbytearray();
void fp_qhash_of_zero_is_zero(); void fp_qhash_of_zero_is_zero();
void qthash_data(); void qthash_data();
void qthash(); void qthash();
@ -117,6 +119,20 @@ void tst_QHashFunctions::qhash()
} }
} }
void tst_QHashFunctions::qhash_of_empty_and_null_qstring()
{
QString null, empty("");
QCOMPARE(null, empty);
QCOMPARE(qHash(null), qHash(empty));
}
void tst_QHashFunctions::qhash_of_empty_and_null_qbytearray()
{
QByteArray null, empty("");
QCOMPARE(null, empty);
QCOMPARE(qHash(null), qHash(empty));
}
void tst_QHashFunctions::fp_qhash_of_zero_is_zero() void tst_QHashFunctions::fp_qhash_of_zero_is_zero()
{ {
QCOMPARE(qHash(-0.0f), 0U); QCOMPARE(qHash(-0.0f), 0U);