From 6b6678bc88e1b53f055b3a7cb8cd30da8ac0e248 Mon Sep 17 00:00:00 2001 From: Mitch Curtis Date: Mon, 26 Jun 2023 15:49:12 +0800 Subject: [PATCH] Doc: state blacklist condition requirement explicitly Each line with a test function must be followed by a line describing the conditions for ignoring that test function. From what I can see, this wasn't explicitly stated anywhere. Fixes: QTBUG-114825 Pick-to: 6.2 6.5 6.6 Change-Id: I1941d6c9a6d56a8374a0c5a99c538cf1eaebd544 Reviewed-by: Edward Welbourne --- src/testlib/qtestblacklist.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/testlib/qtestblacklist.cpp b/src/testlib/qtestblacklist.cpp index 868971fc17..4c30f7b5e9 100644 --- a/src/testlib/qtestblacklist.cpp +++ b/src/testlib/qtestblacklist.cpp @@ -47,7 +47,8 @@ using namespace Qt::StringLiterals; data row's name coincides with that of a local data row, some unintended matches may result; try to keep your data-row tags distinct.) - Subsequent lines give conditions for ignoring this test. + Subsequent lines give conditions for ignoring this test. You need at least + one or the group has no effect. # See qtbase/src/testlib/qtestblacklist.cpp for format # Test doesn't work on QNX at all