QNAM HTTP: Comments

This commit is contained in:
Markus Goetz 2011-04-13 14:16:15 +02:00
parent ea4df8586e
commit 718657d8b2

View File

@ -244,7 +244,7 @@ QNetworkReplyHttpImpl::QNetworkReplyHttpImpl(QNetworkAccessManager* const manage
QNetworkReplyHttpImpl::~QNetworkReplyHttpImpl() QNetworkReplyHttpImpl::~QNetworkReplyHttpImpl()
{ {
// FIXME? // Most work is done in private destructor
} }
void QNetworkReplyHttpImpl::close() void QNetworkReplyHttpImpl::close()
@ -264,35 +264,31 @@ void QNetworkReplyHttpImpl::abort()
qint64 QNetworkReplyHttpImpl::bytesAvailable() const qint64 QNetworkReplyHttpImpl::bytesAvailable() const
{ {
Q_D(const QNetworkReplyHttpImpl); Q_D(const QNetworkReplyHttpImpl);
qDebug() << "QNetworkReplyHttpImpl::bytesAvailable()";
// FIXME cache device // if we load from cache device
if (d->cacheLoadDevice) { if (d->cacheLoadDevice) {
return QNetworkReply::bytesAvailable() + d->cacheLoadDevice->bytesAvailable() + d->downloadMultiBuffer.byteAmount(); return QNetworkReply::bytesAvailable() + d->cacheLoadDevice->bytesAvailable() + d->downloadMultiBuffer.byteAmount();
} }
// FIXME 0-copy buffer // zerocopy buffer
if (d->downloadZerocopyBuffer) { if (d->downloadZerocopyBuffer) {
return QNetworkReply::bytesAvailable() + d->downloadBufferCurrentSize - d->downloadBufferReadPosition; return QNetworkReply::bytesAvailable() + d->downloadBufferCurrentSize - d->downloadBufferReadPosition;
} }
// FIXME normal buffer // normal buffer
qDebug() << "QNetworkReplyHttpImpl::bytesAvailable() ==" << QNetworkReply::bytesAvailable() + d->downloadMultiBuffer.byteAmount();
return QNetworkReply::bytesAvailable() + d->downloadMultiBuffer.byteAmount(); return QNetworkReply::bytesAvailable() + d->downloadMultiBuffer.byteAmount();
// FIXME
} }
bool QNetworkReplyHttpImpl::isSequential () const bool QNetworkReplyHttpImpl::isSequential () const
{ {
// FIXME Maybe not for cache or 0-copy buffer // FIXME In the cache of a cached load or the zero-copy buffer we could actually be non-sequential.
// FIXME however this requires us to implement stuff like seek() too.
return true; return true;
} }
qint64 QNetworkReplyHttpImpl::size() const qint64 QNetworkReplyHttpImpl::size() const
{ {
Q_D(const QNetworkReplyHttpImpl); // FIXME At some point, this could return a proper value, e.g. if we're non-sequential.
//return -1;
return QNetworkReply::size(); return QNetworkReply::size();
} }