AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enabled passing tests in tst_qgraphicsview

Browse Source 
To increase the effective test coverage, this patch
re-enables the tst_qgraphicsview test case as such, and
instead disables only the test functions that are currently
failing in CI.

Task-number: QTBUG-22453
Change-Id: I6b8eb09000ece789b990a2dd697cdb8b47cc8e1c
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
This commit is contained in:
Jo Asplin 2011-10-31 10:25:35 +01:00 committed by Qt by Nokia
parent b92fed185e
commit 718f58487d
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/auto/widgets/graphicsview/qgraphicsview/qgraphicsview.pro
View File

@ -6,6 +6,3 @@ QT += core-private gui-private
SOURCES += tst_qgraphicsview.cpp tst_qgraphicsview_2.cpp SOURCES += tst_qgraphicsview.cpp tst_qgraphicsview_2.cpp
DEFINES += QT_NO_CAST_TO_ASCII DEFINES += QT_NO_CAST_TO_ASCII
# ### fixme: QTBUG-20756 crashes on xcb
contains(QT_CONFIG,xcb):CONFIG+=insignificant_test

2
tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp
View File

@ -4149,6 +4149,7 @@ void tst_QGraphicsView::inputContextReset()
scene.setFocusItem(0); scene.setFocusItem(0);
// the input context is reset twice, once because an item has lost focus and again because // the input context is reset twice, once because an item has lost focus and again because
// the Qt::WA_InputMethodEnabled flag is cleared because no item has focus. // the Qt::WA_InputMethodEnabled flag is cleared because no item has focus.
QEXPECT_FAIL("", "QTBUG-22454", Abort);
QCOMPARE(inputContext->resets, 2); QCOMPARE(inputContext->resets, 2);
// introduce another item that is focusable but does not accept input methods // introduce another item that is focusable but does not accept input methods
@ -4285,6 +4286,7 @@ void tst_QGraphicsView::task255529_transformationAnchorMouseAndViewportMargins()
QPointF newMouseScenePos = view.mapToScene(mouseViewPos); QPointF newMouseScenePos = view.mapToScene(mouseViewPos);
qreal slack = 1; qreal slack = 1;
QEXPECT_FAIL("", "QTBUG-22455", Abort);
QVERIFY(qAbs(newMouseScenePos.x() - mouseScenePos.x()) < slack); QVERIFY(qAbs(newMouseScenePos.x() - mouseScenePos.x()) < slack);
QVERIFY(qAbs(newMouseScenePos.y() - mouseScenePos.y()) < slack); QVERIFY(qAbs(newMouseScenePos.y() - mouseScenePos.y()) < slack);
} }