From 76746ddab6fc44601d036e0bd3c0000aa6f18f0e Mon Sep 17 00:00:00 2001 From: Dmitry Shachnev Date: Sat, 10 Sep 2016 14:14:32 +0300 Subject: [PATCH] QApplication: use desktopStyleKey if styleOverride was invalid When the application is passed an invalid style option, we should fall back to the style provided by the platform theme, not to the first available style. Change-Id: I59e25b00d4a32221dea7c960d0f4e0068247b2dd Reviewed-by: Friedemann Kleint --- src/widgets/kernel/qapplication.cpp | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/widgets/kernel/qapplication.cpp b/src/widgets/kernel/qapplication.cpp index 9b8677e6a8..7fa3b26e45 100644 --- a/src/widgets/kernel/qapplication.cpp +++ b/src/widgets/kernel/qapplication.cpp @@ -1068,15 +1068,17 @@ QStyle *QApplication::style() if (!QApplicationPrivate::app_style) { // Compile-time search for default style // - QString style; - if (!QApplicationPrivate::styleOverride.isEmpty()) { - style = QApplicationPrivate::styleOverride.toLower(); - } else { - style = QApplicationPrivate::desktopStyleKey(); - } - QStyle *&app_style = QApplicationPrivate::app_style; - app_style = QStyleFactory::create(style); + + if (!QApplicationPrivate::styleOverride.isEmpty()) { + const QString style = QApplicationPrivate::styleOverride.toLower(); + app_style = QStyleFactory::create(style); + if (!app_style) + qWarning("QApplication: invalid style override passed, ignoring it."); + } + if (!app_style) + app_style = QStyleFactory::create(QApplicationPrivate::desktopStyleKey()); + if (!app_style) { const QStringList styles = QStyleFactory::keys(); for (const auto &style : styles) {