AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QStringList: refactor a unittest

Browse Source 
- Initialize QStringList with an initializer_list instead of old style
  operator <<()
- Use Qt::StringLiterals more, better readability
- Test CaseSensitivity

Change-Id: If7dde14333d54b8c2f682036634ad94d5f9f9c74
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Ahmad Samir 2023-09-13 14:27:45 +03:00
parent ab651c22ae
commit 76afc35328
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/auto/corelib/text/qstringlist/tst_qstringlist.cpp
View File

@ -11,6 +11,8 @@
#include <algorithm>
using namespace Qt::StringLiterals;
class tst_QStringList : public QObject
{
Q_OBJECT
@ -151,23 +153,22 @@ void tst_QStringList::lastIndexOf()
void tst_QStringList::filter()
{
QStringList list1, list2;
list1 << "Bill Gates" << "Joe Blow" << "Bill Clinton";
list1 = list1.filter( "Bill" );
list2 << "Bill Gates" << "Bill Clinton";
QCOMPARE( list1, list2 );
const QStringList list = {u"Bill Gates"_s, u"Joe Blow"_s, u"Bill Clinton"_s, u"bIll"_s};
QStringList list5, list6;
list5 << "Bill Gates" << "Joe Blow" << "Bill Clinton";
list5 = list5.filter( QRegularExpression("[i]ll") );
list6 << "Bill Gates" << "Bill Clinton";
QCOMPARE( list5, list6 );
{ // CaseSensitive
const QStringList expected{u"Bill Gates"_s, u"Bill Clinton"_s};
QCOMPARE(list.filter(u"Bill"_s), expected);
QCOMPARE(list.filter(u"Bill"), expected);
QCOMPARE(list.filter(QRegularExpression(u"[i]ll"_s)), expected);
}
QStringList list7, list8;
list7 << "Bill Gates" << "Joe Blow" << "Bill Clinton";
list7 = list7.filter( QStringView(QString("Bill")) );
list8 << "Bill Gates" << "Bill Clinton";
QCOMPARE( list7, list8 );
{ // CaseInsensitive
const QStringList expected = {u"Bill Gates"_s, u"Bill Clinton"_s, u"bIll"_s};
QCOMPARE(list.filter(u"bill"_s, Qt::CaseInsensitive), expected);
QCOMPARE(list.filter(u"bill", Qt::CaseInsensitive), expected);
QCOMPARE(list.filter(QRegularExpression(u"[i]ll"_s, QRegularExpression::CaseInsensitiveOption)),
expected);
}
}
void tst_QStringList::sort()