QFrame: add unit test

This test shows a behavior change of setFrameStyle(QFrame::WinPanel)
between 4.4 and 4.5.
Turns out that 4.4 defaulted to "Raised" only via a side effect of the
code, while 4.5 defaults to "Plain" which makes more sense since Plain
is the default anyway. So there is no actual bug to fix (the app code
really meant QFrame::WinPanel|QFrame::Raised anyway), but the unittest
is still good to have for the future.

Done-with: David Faure
Change-Id: Icf16382504b18357256bc601b1e865abac9f2b2a
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
This commit is contained in:
David Faure 2009-08-04 12:17:59 +02:00 committed by Giuseppe D'Angelo
parent 62a647956e
commit 7afc6d6277
4 changed files with 70 additions and 0 deletions

View File

@ -0,0 +1 @@
tst_qframe

View File

@ -0,0 +1,8 @@
CONFIG += testcase
TARGET = tst_qframe
QT += testlib widgets
SOURCES += tst_qframe.cpp
TESTDATA += images/*

View File

@ -0,0 +1,60 @@
/****************************************************************************
**
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
** Copyright (C) 2014 Klarälvdalens Datakonsult AB, a KDAB Group company, info@kdab.com, author Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
** Contact: http://www.qt-project.org/legal
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL21$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia. For licensing terms and
** conditions see http://qt.digia.com/licensing. For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 or version 3 as published by the Free
** Software Foundation and appearing in the file LICENSE.LGPLv21 and
** LICENSE.LGPLv3 included in the packaging of this file. Please review the
** following information to ensure the GNU Lesser General Public License
** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights. These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QTest>
#include <QFrame>
class tst_QFrame : public QObject
{
Q_OBJECT
private slots:
void testDefaults();
};
Q_DECLARE_METATYPE(QFrame::Shape)
Q_DECLARE_METATYPE(QFrame::Shadow)
void tst_QFrame::testDefaults()
{
QFrame frame;
QCOMPARE(frame.frameStyle(), int(QFrame::NoFrame | QFrame::Plain));
frame.setFrameShape(QFrame::Box);
QCOMPARE(frame.frameStyle(), int(QFrame::Box | QFrame::Plain));
frame.setFrameStyle(QFrame::Box); // no shadow specified!
QCOMPARE(frame.frameStyle(), int(QFrame::Box));
}
QTEST_MAIN(tst_QFrame)
#include "tst_qframe.moc"

View File

@ -16,6 +16,7 @@ SUBDIRS=\
qdoublespinbox \
qfocusframe \
qfontcombobox \
qframe \
qgroupbox \
qkeysequenceedit \
qlabel \