AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent QWindow transient parent loop

Browse Source 
Clients may wrongly set the transient parent to the window itself,
causing endless loop when e.g. looking for the top level parent.

Change-Id: Ib23cae3a5576320435ae9b76dd618d1e5ae08b5d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
This commit is contained in:
Tor Arne Vestbø 2017-04-10 21:07:11 +02:00
parent 6e649f9714
commit 7f29367c09
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/kernel/qwindow.cpp
View File

@ -1279,6 +1279,10 @@ void QWindow::setTransientParent(QWindow *parent)
qWarning() << parent << "must be a top level window."; qWarning() << parent << "must be a top level window.";
return; return;
} }
if (parent == this) {
qWarning() << "transient parent" << parent << "can not be same as window";
return;
}
d->transientParent = parent; d->transientParent = parent;