AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused function _q_qgraphicsItemSetFlag

Browse Source 
Clang reports:
graphicsview/qgraphicsitem.cpp:1779:13: error: function '_q_qgraphicsItemSetFlag' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag,
            ^

According to the public Git history, in Qt 4.5.1 this function was
already unused. The only reason it wasn't caught so far is that it is
recursive: it calls itself. So it is used... by itself.

Change-Id: I6fc6b33cb314b845525dc9315d0ad742e113d5cd
Reviewed-by: Andreas Aardal Hanssen <andreas@hanssen.name>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
This commit is contained in:
Thiago Macieira 2012-12-28 20:38:19 -02:00 committed by The Qt Project
parent fbfe420aeb
commit 8094c8fe18
1 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/widgets/graphicsview/qgraphicsitem.cpp
View File

@ -1771,24 +1771,6 @@ void QGraphicsItem::setFlag(GraphicsItemFlag flag, bool enabled)
setFlags(GraphicsItemFlags(d_ptr->flags) & ~flag);
}
/*!
\internal
Sets the flag \a flag on \a item and all its children, to \a enabled.
*/
static void _q_qgraphicsItemSetFlag(QGraphicsItem *item, QGraphicsItem::GraphicsItemFlag flag,
bool enabled)
{
if (item->flags() & flag) {
// If this item already has the correct flag set, we don't have to
// propagate it.
return;
}
item->setFlag(flag, enabled);
foreach (QGraphicsItem *child, item->childItems())
_q_qgraphicsItemSetFlag(child, flag, enabled);
}
/*!
Sets the item flags to \a flags. All flags in \a flags are enabled; all
flags not in \a flags are disabled.