QLibrary: Suppress GCC 12 warning about dangling pointer access

Introduced in commit d07742f333. Reported
by GCC 12:

qlibrary.cpp:672:9: error: dangling pointer to ‘candidates’ may be used [-Werror=dangling-pointer=]
  672 |         if (isValidSuffix(*it++))
      |         ^~
qlibrary.cpp:634:29: note: ‘candidates’ declared here
  634 |         const QLatin1String candidates[] = {
      |                             ^~~~~~~~~~

This is a false positive report because the lambda does not return a
pointer or iterator. But it's a good update anyway to keep the array
outside the lambda, so it won't be recreated every time.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104492

Pick-to: 6.3
Change-Id: I74249c52dc02478ba93cfffd16d230abd1bf6166
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
This commit is contained in:
Thiago Macieira 2022-02-09 10:12:08 -08:00
parent 0a41399c2d
commit 81b9ee66b8

View File

@ -629,29 +629,30 @@ bool QLibrary::isLibrary(const QString &fileName)
if (completeSuffix.isEmpty())
return false;
auto isValidSuffix = [](QStringView s) {
// if this throws an empty-array error, you need to fix the #ifdef's:
const QLatin1String candidates[] = {
// if this throws an empty-array error, you need to fix the #ifdef's:
const QLatin1String candidates[] = {
# if defined(Q_OS_HPUX)
/*
See "HP-UX Linker and Libraries User's Guide", section "Link-time Differences between PA-RISC and IPF":
"In PA-RISC (PA-32 and PA-64) shared libraries are suffixed with .sl. In IPF (32-bit and 64-bit),
the shared libraries are suffixed with .so. For compatibility, the IPF linker also supports the .sl suffix."
*/
QLatin1String("sl"),
*/
QLatin1String("sl"),
# if defined __ia64
QLatin1String("so"),
QLatin1String("so"),
# endif
# elif defined(Q_OS_AIX)
QLatin1String("a"),
QLatin1String("so"),
QLatin1String("a"),
QLatin1String("so"),
# elif defined(Q_OS_DARWIN)
QLatin1String("so"),
QLatin1String("bundle"),
QLatin1String("so"),
QLatin1String("bundle"),
# elif defined(Q_OS_UNIX)
QLatin1String("so"),
QLatin1String("so"),
# endif
}; // candidates
}; // candidates
auto isValidSuffix = [&candidates](QStringView s) {
return std::find(std::begin(candidates), std::end(candidates), s) != std::end(candidates);
};