From 83dac218130a5e91616d1cd515815f0ce9b6c332 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Mon, 27 Feb 2023 17:44:45 +0100 Subject: [PATCH] DNS Lookup: Use standard functions to print version/help showHelp was already in use, but not showVersion. Return 0 in both cases, even if it's unreachable. Task-number: QTBUG-108873 Pick-to: 6.5 Change-Id: Iba820e89d7de066130163e7829f75bbfcfa3f7dd Reviewed-by: Marc Mutz --- examples/network/dnslookup/dnslookup.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/network/dnslookup/dnslookup.cpp b/examples/network/dnslookup/dnslookup.cpp index 1fe2eaceb9..62ad622346 100644 --- a/examples/network/dnslookup/dnslookup.cpp +++ b/examples/network/dnslookup/dnslookup.cpp @@ -205,12 +205,11 @@ int main(int argc, char *argv[]) fputs(qPrintable(parser.helpText()), stderr); return 1; case CommandLineVersionRequested: - printf("%s %s\n", qPrintable(QCoreApplication::applicationName()), - qPrintable(QCoreApplication::applicationVersion())); - return 0; + parser.showVersion(); + Q_UNREACHABLE_RETURN(0); case CommandLineHelpRequested: parser.showHelp(); - Q_UNREACHABLE(); + Q_UNREACHABLE_RETURN(0); } //! [1]