AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QRegularExpression: operator<<(QDebug, PatternOptions) improvements

Browse Source 
Avoid building a QStringList and then joining the strings with pipes;
directly append the flags to a QByteArray instead.

Change-Id: Ic352b756ed1e3b6b579b9ca412636a2b394d2eb5
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
Giuseppe D'Angelo 2012-03-23 05:51:11 +00:00 committed by Qt by Nokia
parent 0556540b41
commit 989b7f2337
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/corelib/tools/qregularexpression.cpp
View File

@ -2153,30 +2153,30 @@ QDebug operator<<(QDebug debug, const QRegularExpression &re)
*/
QDebug operator<<(QDebug debug, QRegularExpression::PatternOptions patternOptions)
{
QStringList flags;
QByteArray flags;
if (patternOptions == QRegularExpression::NoPatternOption) {
flags << QLatin1String("NoPatternOption");
flags = "NoPatternOption";
} else {
flags.reserve(200); // worst case...
if (patternOptions & QRegularExpression::CaseInsensitiveOption)
flags << QLatin1String("CaseInsensitiveOption");
flags.append("CaseInsensitiveOption|");
if (patternOptions & QRegularExpression::DotMatchesEverythingOption)
flags << QLatin1String("DotMatchesEverythingOption");
flags.append("DotMatchesEverythingOption|");
if (patternOptions & QRegularExpression::MultilineOption)
flags << QLatin1String("MultilineOption");
flags.append("MultilineOption|");
if (patternOptions & QRegularExpression::ExtendedPatternSyntaxOption)
flags << QLatin1String("ExtendedPatternSyntaxOption");
flags.append("ExtendedPatternSyntaxOption|");
if (patternOptions & QRegularExpression::InvertedGreedinessOption)
flags << QLatin1String("InvertedGreedinessOption");
flags.append("InvertedGreedinessOption|");
if (patternOptions & QRegularExpression::DontCaptureOption)
flags << QLatin1String("DontCaptureOption");
flags.append("DontCaptureOption|");
if (patternOptions & QRegularExpression::UseUnicodePropertiesOption)
flags << QLatin1String("UseUnicodePropertiesOption");
flags.append("UseUnicodePropertiesOption|");
flags.chop(1);
}
debug.nospace() << "QRegularExpression::PatternOptions("
<< qPrintable(flags.join(QLatin1String("|")))
<< ")";
debug.nospace() << "QRegularExpression::PatternOptions(" << flags << ")";
return debug.space();
}