AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Doc: fix link to QTest::failOnWarning

Browse Source 
Also fix incorrect failOnWarning*s* elsewhere in comments.

Pick-to: 6.5 6.5.0
Change-Id: I0bbc5e71060348153876f3d9a7c77c67f3c2e00d
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Volker Hilsheimer 2023-03-01 17:02:31 +01:00
parent 9ec61d4460
commit 9e31631557
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/testlib/doc/src/qttest-best-practices.qdoc
View File

@ -383,12 +383,12 @@
only tell you whether \e{the test} was built in debug mode, and that does
not guarantee that the \e{Qt libraries} were also built in debug mode.
Your tests can (since Qt 6.3) verify that they do not trigger calls to \l
qWarning() by calling \l QTest::failOnWarnings(). This takes the warning
Your tests can (since Qt 6.3) verify that they do not trigger calls to
\l qWarning() by calling \l QTest::failOnWarning(). This takes the warning
message to test for or a \l QRegularExpression to match against warnings; if
a matching warning is produced, it will be reported and cause the test to
fail. For example, a test that should produce no warnings at all can
\c{QTest::failOnWarnings(QRegularExpression(u".*"_s))}, which will match any
\c{QTest::failOnWarning(QRegularExpression(u".*"_s))}, which will match any
warning at all.
You can also set the environment variable \c QT_FATAL_WARNINGS to cause

2
src/testlib/qtestlog.cpp
View File

@ -179,7 +179,7 @@ namespace QTest {
static bool handleFailOnWarning(const QMessageLogContext &context, const QString &message)
{
// failOnWarnings can be called multiple times per test function, so let
// failOnWarning can be called multiple times per test function, so let
// each call cause a failure if required.
for (const auto &pattern : failOnWarningList) {
if (pattern.metaType() == QMetaType::fromType<QString>()) {

2
tests/auto/testlib/selftests/warnings/tst_warnings.cpp
View File

@ -115,7 +115,7 @@ void tst_Warnings::testMissingWarningsWithData()
void tst_Warnings::testFailOnWarnings()
{
// failOnWarnings() wasn't called yet; shouldn't fail;
// failOnWarning() wasn't called yet; shouldn't fail;
qWarning("Ran out of space!");
#if QT_CONFIG(regularexpression)