From ab68958213b607a0f36e624a0a36d0f76aea654c Mon Sep 17 00:00:00 2001 From: Jakub Adam Date: Wed, 4 Jun 2014 14:48:02 +0200 Subject: [PATCH] Use correct signal name when disconnecting "NameOwnerChanged" A disconnectSignal() call with a wrong signal name caused that hook wasn't found and thus kept in QDBusConnectionPrivate::signalHooks forever. Change-Id: Id7cda225be7580529fc835b377636226abb229f9 Reviewed-by: Aaron McCarthy Reviewed-by: Thiago Macieira --- src/dbus/qdbusintegrator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dbus/qdbusintegrator.cpp b/src/dbus/qdbusintegrator.cpp index 1fef6d4d49..d4079e8076 100644 --- a/src/dbus/qdbusintegrator.cpp +++ b/src/dbus/qdbusintegrator.cpp @@ -2267,7 +2267,7 @@ QDBusConnectionPrivate::disconnectSignal(SignalHookHash::Iterator &it) watchedServices.erase(sit); disconnectSignal(dbusServiceString(), QString(), dbusInterfaceString(), QLatin1String("NameOwnerChanged"), QStringList() << hook.service, QString(), - this, SLOT(_q_serviceOwnerChanged(QString,QString,QString))); + this, SLOT(serviceOwnerChangedNoLock(QString,QString,QString))); } } }