From c2800e75550b1aeea753fbdfe2c6672b5ee931b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Tue, 11 Sep 2018 14:31:32 +0300 Subject: [PATCH 1/8] Remove insignificant flag from qcolordialog.pro MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As the test was unstable, we qskip the failing parts instead of mark the whole test insignificant. Task-number: QTBUG-50842 Change-Id: Ib8f5b7ead07d65cc624fa72b190ecee0338c8183 Reviewed-by: Tony Sarajärvi Reviewed-by: Heikki Halmet --- tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro | 2 -- .../auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro b/tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro index c8ddedb401..563db6e887 100644 --- a/tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro +++ b/tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro @@ -2,5 +2,3 @@ CONFIG += testcase TARGET = tst_qcolordialog QT += widgets testlib SOURCES += tst_qcolordialog.cpp - -linux*: CONFIG += insignificant_test # Crashes on different Linux distros diff --git a/tests/auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp b/tests/auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp index 0df0544a06..6a0ad4b3a4 100644 --- a/tests/auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp +++ b/tests/auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp @@ -84,6 +84,9 @@ void tst_QColorDialog::testNativeActiveModalWidget() // Check that QApplication::activeModalWidget retruns the // color dialog when it is executing, even when using a native // dialog: +#if defined(Q_OS_LINUX) + QSKIP("This test crashes sometimes. Although rarely, but it happens. See QTBUG-50842."); +#endif TestNativeDialog d; QTimer::singleShot(1000, &d, SLOT(hide())); d.exec(); @@ -121,6 +124,9 @@ void tst_QColorDialog::testGetRgba() void tst_QColorDialog::defaultOkButton() { +#if defined(Q_OS_LINUX) + QSKIP("This test crashes sometimes. Although rarely, but it happens. See QTBUG-50842."); +#endif QTimer::singleShot(4000, qApp, SLOT(quit())); QTimer::singleShot(0, this, SLOT(testGetRgba())); qApp->exec(); From e0ba6e09c0e6e501ffbee36d957451251194ab4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Tue, 18 Sep 2018 13:17:45 +0300 Subject: [PATCH 2/8] Blacklist flaky tst_qheaderview test Task-number: QTBUG-70590 Change-Id: I39ca2a7207db58d1a33bb918e065196a60471930 Reviewed-by: Liang Qi --- tests/auto/widgets/itemviews/qheaderview/BLACKLIST | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/auto/widgets/itemviews/qheaderview/BLACKLIST diff --git a/tests/auto/widgets/itemviews/qheaderview/BLACKLIST b/tests/auto/widgets/itemviews/qheaderview/BLACKLIST new file mode 100644 index 0000000000..efb813f7d2 --- /dev/null +++ b/tests/auto/widgets/itemviews/qheaderview/BLACKLIST @@ -0,0 +1,3 @@ +[stretchAndRestoreLastSection] +opensuse +opensuse-leap From 619e37c83bd32f5d8c36a1e447cf825cb0b11be4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Tue, 18 Sep 2018 13:29:08 +0300 Subject: [PATCH 3/8] Extend blacklisting of qtimeline::frameRate to macOS 10.13 This is already blacklisted for macOS 10.12 and reproducing in 10.13. Task-number: QTBUG-61037 Change-Id: I464e42d0ae5ab24104250edc69a90454ba605eaa Reviewed-by: Liang Qi --- tests/auto/corelib/tools/qtimeline/BLACKLIST | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/auto/corelib/tools/qtimeline/BLACKLIST b/tests/auto/corelib/tools/qtimeline/BLACKLIST index 958563d15e..5611969b4d 100644 --- a/tests/auto/corelib/tools/qtimeline/BLACKLIST +++ b/tests/auto/corelib/tools/qtimeline/BLACKLIST @@ -6,3 +6,4 @@ osx-10.13 windows [frameRate] osx-10.12 +osx-10.13 From 17187265cbc8b883be182f8ed38e759fa3e52c84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Tue, 18 Sep 2018 13:45:30 +0300 Subject: [PATCH 4/8] Blacklist qguiapplication::focusObject on Ubuntu and openSUSE Task-number: QTBUG-70593 Change-Id: Ibad362cbc6660835a05412a612f34cfdaee5932c Reviewed-by: Liang Qi --- tests/auto/gui/kernel/qguiapplication/BLACKLIST | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 tests/auto/gui/kernel/qguiapplication/BLACKLIST diff --git a/tests/auto/gui/kernel/qguiapplication/BLACKLIST b/tests/auto/gui/kernel/qguiapplication/BLACKLIST new file mode 100644 index 0000000000..9a670237b7 --- /dev/null +++ b/tests/auto/gui/kernel/qguiapplication/BLACKLIST @@ -0,0 +1,4 @@ +[focusObject] +opensuse +opensuse-leap +ubuntu From a1eaa71e61fdb15d5d3da373cd2b0f99aab6c35a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Wed, 19 Sep 2018 09:02:37 +0300 Subject: [PATCH 5/8] Blacklist flaky tst_QGraphicsEffect autotest on openSUSE Task-number: QTBUG-70612 Change-Id: I7254ca7a0dd1bce92bd6d8841e53af5acdd78807 Reviewed-by: Liang Qi --- tests/auto/widgets/effects/qgraphicseffect/BLACKLIST | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/auto/widgets/effects/qgraphicseffect/BLACKLIST diff --git a/tests/auto/widgets/effects/qgraphicseffect/BLACKLIST b/tests/auto/widgets/effects/qgraphicseffect/BLACKLIST new file mode 100644 index 0000000000..4833af527f --- /dev/null +++ b/tests/auto/widgets/effects/qgraphicseffect/BLACKLIST @@ -0,0 +1,3 @@ +[prepareGeometryChangeInvalidateCache] +opensuse +opensuse-leap From 1ccc2348b3b479665814d51421a3e32ef09dcf42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Wed, 19 Sep 2018 11:14:21 +0300 Subject: [PATCH 6/8] Extend blacklisting of tst_qparallelanimationgroup tests to macOS 10.13 Task-number: QTBUG-61500 Change-Id: I46b10b6ecd7f1653bebd0ffd6f250f5c65cb8189 Reviewed-by: Liang Qi --- tests/auto/corelib/animation/qparallelanimationgroup/BLACKLIST | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/auto/corelib/animation/qparallelanimationgroup/BLACKLIST b/tests/auto/corelib/animation/qparallelanimationgroup/BLACKLIST index fe1d5bd968..b5b37b4498 100644 --- a/tests/auto/corelib/animation/qparallelanimationgroup/BLACKLIST +++ b/tests/auto/corelib/animation/qparallelanimationgroup/BLACKLIST @@ -1,2 +1,3 @@ [deleteChildrenWithRunningGroup] osx-10.12 +osx-10.13 From 8a763507885309666ae8500c9bdea9af5d46be28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tony=20Saraj=C3=A4rvi?= Date: Thu, 20 Sep 2018 11:44:13 +0300 Subject: [PATCH 7/8] Blacklist flaky qgraphicsscene autotests Task-number: QTBUG-70640 Change-Id: I2a958652ed9fee9cbf2cd367e99aa672c744e74b Reviewed-by: Liang Qi --- .../widgets/graphicsview/qgraphicsscene/BLACKLIST | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/auto/widgets/graphicsview/qgraphicsscene/BLACKLIST b/tests/auto/widgets/graphicsview/qgraphicsscene/BLACKLIST index 70170d2822..0e7a1b451f 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsscene/BLACKLIST +++ b/tests/auto/widgets/graphicsview/qgraphicsscene/BLACKLIST @@ -3,3 +3,15 @@ osx-10.11 ci [isActive] opensuse-42.3 ci +[removeFullyTransparentItem] +osx-10.11 +osx-10.12 +[tabFocus_sceneWithNestedFocusWidgets] +opensuse +opensuse-leap +[inputMethod] +opensuse +opensuse-leap +[hoverEvents_parentChild] +ubuntu + From b4b706d454b785aecbec5cefe46e2a6d7572edbf Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Thu, 13 Sep 2018 13:42:16 +0200 Subject: [PATCH 8/8] Ensure that QTabletEvent is not pre-accepted before sending In QWidget-world it's normal for input events to have the accepted flag false by default, so that it's obvious after visiting a widget subclass that does not override a particular handler function that it did not handle that event type at all. For tablet events in particular, the contract (to which we've been paying more attention to ensure that QTBUG-47007 remains properly fixed) is that if a QTabletEvent is not accepted, a mouse event will follow. Tablet-unaware applications need to get the same mouse events from a Wacom stylus as they would receive from an actual mouse. In this case the issue was missing hover events (mouse movements in which no mouse button is pressed). Without those, the enterEvent and exitEvent virtuals are also not invoked properly. Task-number: QTBUG-47007 Task-number: QTBUG-65199 Change-Id: I957005aad9d2bf85a3a41bbdebe3e046e34dee4d Reviewed-by: Andy Shaw --- src/widgets/kernel/qapplication.cpp | 1 + src/widgets/kernel/qwidgetwindow.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/widgets/kernel/qapplication.cpp b/src/widgets/kernel/qapplication.cpp index 581b7c9c94..038226c521 100644 --- a/src/widgets/kernel/qapplication.cpp +++ b/src/widgets/kernel/qapplication.cpp @@ -3388,6 +3388,7 @@ bool QApplication::notify(QObject *receiver, QEvent *e) tablet->tangentialPressure(), tablet->rotation(), tablet->z(), tablet->modifiers(), tablet->uniqueId(), tablet->button(), tablet->buttons()); te.spont = e->spontaneous(); + te.setAccepted(false); res = d->notify_helper(w, w == receiver ? tablet : &te); eventAccepted = ((w == receiver) ? tablet : &te)->isAccepted(); e->spont = false; diff --git a/src/widgets/kernel/qwidgetwindow.cpp b/src/widgets/kernel/qwidgetwindow.cpp index 1a2ac4a4dd..7292c795b8 100644 --- a/src/widgets/kernel/qwidgetwindow.cpp +++ b/src/widgets/kernel/qwidgetwindow.cpp @@ -1044,6 +1044,7 @@ void QWidgetWindow::handleTabletEvent(QTabletEvent *event) event->pressure(), event->xTilt(), event->yTilt(), event->tangentialPressure(), event->rotation(), event->z(), event->modifiers(), event->uniqueId(), event->button(), event->buttons()); ev.setTimestamp(event->timestamp()); + ev.setAccepted(false); QGuiApplication::forwardEvent(widget, &ev, event); event->setAccepted(ev.isAccepted()); }