Prefer QSKIP to QTEST_NOOP_MAIN.

Use QSKIP instead of QTEST_NOOP_MAIN so that the user receives a clear
indication that this test isn't testing anything when not built for X11.

Change-Id: I9e9ef8fe738c06eb86f2ce398f6a515bf17e220a
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
This commit is contained in:
Jason McDonald 2011-10-17 15:11:12 +10:00 committed by Qt by Nokia
parent 946805f07f
commit afb80f0cd9
2 changed files with 17 additions and 11 deletions

View File

@ -1,4 +1,5 @@
load(qttest_p4)
QT += widgets
SOURCES += tst_qx11info.cpp

View File

@ -41,9 +41,6 @@
#include <QtTest/QtTest>
#ifdef Q_WS_X11
#include <QApplication>
#include <QX11Info>
@ -51,10 +48,23 @@ class tst_QX11Info : public QObject
{
Q_OBJECT
#ifndef Q_WS_X11
public slots:
void initTestCase();
#else
private slots:
void staticFunctionsBeforeQApplication();
#endif
};
#ifndef Q_WS_X11
void tst_QX11Info::initTestCase()
{
QSKIP("This test is only valid for X11", SkipAll);
}
#else
void tst_QX11Info::staticFunctionsBeforeQApplication()
{
QVERIFY(!QApplication::instance());
@ -111,12 +121,7 @@ void tst_QX11Info::staticFunctionsBeforeQApplication()
QCOMPARE(appTime, 0ul);
}
QTEST_APPLESS_MAIN(tst_QX11Info)
#include "tst_qx11info.moc"
#else // !Q_WS_X11
QTEST_NOOP_MAIN
#endif
QTEST_APPLESS_MAIN(tst_QX11Info)
#include "tst_qx11info.moc"