AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Qt should not print warning unless we have an API miss-usage case

Browse Source 
This warning is always printed.

Change-Id: I524011f251f7f7e0d76eb94b16e1511e72f26422
Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
This commit is contained in:
Alex Blasche 2014-12-18 08:58:59 +01:00 committed by Kai Koehne
parent 8eb4b281d9
commit b8e71aa847
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/bearer/networkmanager/qnetworkmanagerservice.cpp
View File

@ -146,7 +146,7 @@ QDBusInterface *QNetworkManagerInterface::connectionInterface() const
QList <QDBusObjectPath> QNetworkManagerInterface::getDevices() QList <QDBusObjectPath> QNetworkManagerInterface::getDevices()
{ {
if (devicesPathList.isEmpty()) { if (devicesPathList.isEmpty()) {
qWarning() << "using blocking call!"; //qWarning() << "using blocking call!";
QDBusReply<QList<QDBusObjectPath> > reply = d->connectionInterface->call(QLatin1String("GetDevices")); QDBusReply<QList<QDBusObjectPath> > reply = d->connectionInterface->call(QLatin1String("GetDevices"));
devicesPathList = reply.value(); devicesPathList = reply.value();
} }
@ -779,7 +779,7 @@ QDBusInterface *QNetworkManagerInterfaceDeviceWireless::connectionInterface() co
QList <QDBusObjectPath> QNetworkManagerInterfaceDeviceWireless::getAccessPoints() QList <QDBusObjectPath> QNetworkManagerInterfaceDeviceWireless::getAccessPoints()
{ {
if (accessPointsList.isEmpty()) { if (accessPointsList.isEmpty()) {
qWarning() << "Using blocking call!"; //qWarning() << "Using blocking call!";
QDBusReply<QList<QDBusObjectPath> > reply QDBusReply<QList<QDBusObjectPath> > reply
= d->connectionInterface->call(QLatin1String("GetAccessPoints")); = d->connectionInterface->call(QLatin1String("GetAccessPoints"));
accessPointsList = reply.value(); accessPointsList = reply.value();
@ -997,7 +997,7 @@ bool QNetworkManagerSettings::setConnections()
QList <QDBusObjectPath> QNetworkManagerSettings::listConnections() QList <QDBusObjectPath> QNetworkManagerSettings::listConnections()
{ {
if (connectionsList.isEmpty()) { if (connectionsList.isEmpty()) {
qWarning() << "Using blocking call!"; //qWarning() << "Using blocking call!";
QDBusReply<QList<QDBusObjectPath> > reply QDBusReply<QList<QDBusObjectPath> > reply
= d->connectionInterface->call(QLatin1String("ListConnections")); = d->connectionInterface->call(QLatin1String("ListConnections"));
connectionsList = reply.value(); connectionsList = reply.value();
@ -1103,7 +1103,7 @@ QDBusInterface *QNetworkManagerSettingsConnection::connectionInterface() const
QNmSettingsMap QNetworkManagerSettingsConnection::getSettings() QNmSettingsMap QNetworkManagerSettingsConnection::getSettings()
{ {
if (d->settingsMap.isEmpty()) { if (d->settingsMap.isEmpty()) {
qWarning() << "Using blocking call!"; //qWarning() << "Using blocking call!";
QDBusReply<QNmSettingsMap> reply = d->connectionInterface->call(QLatin1String("GetSettings")); QDBusReply<QNmSettingsMap> reply = d->connectionInterface->call(QLatin1String("GetSettings"));
d->settingsMap = reply.value(); d->settingsMap = reply.value();
} }