AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

syncqt: Mention full path and line number when emitting warning

Browse Source 
Makes it easier to navigate to the offending file.

Change-Id: Ie2de5d6a0735952e72444b0ac8710fc44311eace
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
This commit is contained in:
Tor Arne Vestbø 2022-10-03 12:27:11 +02:00
parent affb87741e
commit b93fabddd4
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/tools/syncqt/main.cpp
View File

@ -1126,7 +1126,8 @@ public:
.filename()
.generic_string())) {
faults |= PrivateHeaderChecks;
std::cerr << "ERROR: " << m_currentFilename
std::cerr << "ERROR: " << m_currentFileString
<< ":" << m_currentFileLineNumber
<< " includes private header " << includedHeader << std::endl;
}
for (const auto &module : m_commandLineArgs->knownModules()) {
@ -1134,8 +1135,10 @@ public:
if (std::filesystem::exists(m_commandLineArgs->includeDir() + "/../"
+ suggestedHeader)) {
faults |= IncludeChecks;
std::cerr << "WARNING: " << m_currentFilename << " includes "
<< includedHeader << " when it should include "
std::cerr << "WARNING: " << m_currentFileString
<< ":" << m_currentFileLineNumber
<< " includes " << includedHeader
<< " when it should include "
<< suggestedHeader << std::endl;
}
}
@ -1190,21 +1193,21 @@ public:
if (hasQtBeginNamespace) {
if (qtBeginNamespace != qtEndNamespace) {
faults |= NamespaceChecks;
std::cerr << "WARNING: " << m_currentFilename
std::cerr << "WARNING: " << m_currentFileString
<< " the begin namespace macro QT_BEGIN_NAMESPACE" << qtBeginNamespace
<< " doesn't match the end namespace macro QT_END_NAMESPACE"
<< qtEndNamespace << std::endl;
}
} else {
faults |= NamespaceChecks;
std::cerr << "WARNING: " << m_currentFilename
std::cerr << "WARNING: " << m_currentFileString
<< " does not include QT_BEGIN_NAMESPACE" << std::endl;
}
}
if (!(skipChecks & WeMeantItChecks) && !hasWeMeantIt) {
faults |= WeMeantItChecks;
std::cerr << "WARNING: " << m_currentFilename
std::cerr << "WARNING: " << m_currentFileString
<< " does not have the \"We mean it.\" warning"
<< std::endl;
}