AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make sure to signal only changed configurations

Browse Source 
really use this

Change-Id: I082f8d84da572a2c51f67355dcbc06394940c421
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
This commit is contained in:
Lorn Potter 2013-10-21 10:38:09 +10:00 committed by The Qt Project
parent 9518c17837
commit bfe005a888
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/bearer/connman/qconnmanengine.cpp
View File

@ -350,7 +350,7 @@ void QConnmanEngine::configurationChange(const QString &id)
QMutexLocker locker(&mutex); QMutexLocker locker(&mutex);
if (accessPointConfigurations.contains(id)) { if (accessPointConfigurations.contains(id)) {
bool changed = false;
QNetworkConfigurationPrivatePointer ptr = accessPointConfigurations.value(id); QNetworkConfigurationPrivatePointer ptr = accessPointConfigurations.value(id);
QString servicePath = serviceFromId(id); QString servicePath = serviceFromId(id);
@ -368,18 +368,22 @@ void QConnmanEngine::configurationChange(const QString &id)
if (ptr->name != networkName) { if (ptr->name != networkName) {
ptr->name = networkName; ptr->name = networkName;
changed = true;
} }
if (ptr->state != curState) { if (ptr->state != curState) {
ptr->state = curState; ptr->state = curState;
changed = true;
} }
ptr->mutex.unlock(); ptr->mutex.unlock();
if (changed) {
locker.unlock(); locker.unlock();
emit configurationChanged(ptr); emit configurationChanged(ptr);
locker.relock(); locker.relock();
} }
}
locker.unlock(); locker.unlock();
emit updateCompleted(); emit updateCompleted();