AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove insignificant flag from qcolordialog.pro

Browse Source 
As the test was unstable, we qskip the failing parts
instead of mark the whole test insignificant.

Task-number: QTBUG-50842
Change-Id: Ib8f5b7ead07d65cc624fa72b190ecee0338c8183
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
This commit is contained in:
Tony Sarajärvi 2018-09-11 14:31:32 +03:00
parent 2e94947c56
commit c2800e7555
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/widgets/dialogs/qcolordialog/qcolordialog.pro
View File

@ -2,5 +2,3 @@ CONFIG += testcase
TARGET = tst_qcolordialog
QT += widgets testlib
SOURCES += tst_qcolordialog.cpp
linux*: CONFIG += insignificant_test # Crashes on different Linux distros

6
tests/auto/widgets/dialogs/qcolordialog/tst_qcolordialog.cpp
View File

@ -84,6 +84,9 @@ void tst_QColorDialog::testNativeActiveModalWidget()
// Check that QApplication::activeModalWidget retruns the
// color dialog when it is executing, even when using a native
// dialog:
#if defined(Q_OS_LINUX)
QSKIP("This test crashes sometimes. Although rarely, but it happens. See QTBUG-50842.");
#endif
TestNativeDialog d;
QTimer::singleShot(1000, &d, SLOT(hide()));
d.exec();
@ -121,6 +124,9 @@ void tst_QColorDialog::testGetRgba()
void tst_QColorDialog::defaultOkButton()
{
#if defined(Q_OS_LINUX)
QSKIP("This test crashes sometimes. Although rarely, but it happens. See QTBUG-50842.");
#endif
QTimer::singleShot(4000, qApp, SLOT(quit()));
QTimer::singleShot(0, this, SLOT(testGetRgba()));
qApp->exec();