AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: removed obsolete tst_maketestselftest::tests_auto_pro

Browse Source 
This test attempted to ensure that tests/auto/auto.pro would only refer
to other .pro files, attempting to guarantee that the set of all tests
could be cleanly broken up.  The purpose of this was to enable CI
optimizations (e.g. running the autotests for different modules on
different machines in parallel).

This test is invalidated by pending commits which rearrange the
autotests, and we never made use of this property for optimization
anyway, so drop this part of the test.

Change-Id: I23e712fb8ec1dbe7ac65fe66015e1f060f3dcd41
Reviewed-on: http://codereview.qt.nokia.com/3681
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jo Asplin <jo.asplin@nokia.com>
This commit is contained in:
Rohan McGovern 2011-08-29 09:24:37 +10:00 committed by Jo Asplin
parent a001bde5bf
commit c7013eea59
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/auto/maketestselftest/tst_maketestselftest.cpp
View File

@ -58,8 +58,6 @@ class tst_MakeTestSelfTest: public QObject
Q_OBJECT Q_OBJECT
private slots: private slots:
void tests_auto_pro();
void tests_pro_files(); void tests_pro_files();
void tests_pro_files_data(); void tests_pro_files_data();
@ -78,30 +76,6 @@ bool looks_like_testcase(QString const&,QString*);
bool looks_like_subdirs(QString const&); bool looks_like_subdirs(QString const&);
QStringList find_test_class(QString const&); QStringList find_test_class(QString const&);
/*
Verify that auto.pro only contains other .pro files (and not directories).
We enforce this so that we can process every .pro file other than auto.pro
independently and get all the tests.
If tests were allowed to appear directly in auto.pro, we'd have the problem
that we need to somehow run these tests from auto.pro while preventing
recursion into the other .pro files.
*/
void tst_MakeTestSelfTest::tests_auto_pro()
{
QStringList subdirsList = find_subdirs(SRCDIR "/../auto.pro", Flat);
if (QTest::currentTestFailed()) {
return;
}
foreach (QString const& subdir, subdirsList) {
QVERIFY2(subdir.endsWith(".pro"), qPrintable(QString(
"auto.pro contains a subdir `%1'.\n"
"auto.pro must _only_ contain other .pro files, not actual subdirs.\n"
"Please move `%1' into some other .pro file referenced by auto.pro."
).arg(subdir)));
}
}
/* Verify that all tests are listed somewhere in one of the autotest .pro files */ /* Verify that all tests are listed somewhere in one of the autotest .pro files */
void tst_MakeTestSelfTest::tests_pro_files() void tst_MakeTestSelfTest::tests_pro_files()
{ {