AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Limit value in setFontWeightFromValue()

Browse Source 
QFont::setWeight() just accepts values between 0 and 900 anyway.

Fixes: oss-fuzz-24986
Pick-to: 5.12 5.15
Change-Id: Ic65139a7821be3a12c65444d010736f03c8b74f5
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Robert Loehning 2020-10-09 11:57:10 +02:00
parent ec1d553bbf
commit ccc205bf38
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/gui/text/qcssparser.cpp
View File

@ -1195,7 +1195,8 @@ static bool setFontWeightFromValue(const QCss::Value &value, QFont *font)
} }
if (value.type != Value::Number) if (value.type != Value::Number)
return false; return false;
font->setWeight(QFont::Weight(value.variant.toInt())); // .toInt() would call qRound64() and might overflow the long long there
font->setWeight(QFont::Weight(qRound(qBound(0.0, value.variant.toDouble(), 1001.0))));
return true; return true;
} }