AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Micro-optimization of list string list construction in qmetaobject.

Browse Source 
We know the size of constructed list, so it may be worth to reserve
memory space for it.

Change-Id: Idad061bc1dbf5acecaec48d2e00ca3504b9db8b8
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
This commit is contained in:
Jędrzej Nowacki 2013-04-10 11:52:31 +02:00 committed by The Qt Project
parent 7628e6ed1a
commit d121b37a4a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/corelib/kernel/qmetaobject.cpp
View File

@ -1671,8 +1671,9 @@ void QMetaMethodPrivate::getParameterTypes(int *types) const
QList<QByteArray> QMetaMethodPrivate::parameterTypes() const QList<QByteArray> QMetaMethodPrivate::parameterTypes() const
{ {
Q_ASSERT(priv(mobj->d.data)->revision >= 7); Q_ASSERT(priv(mobj->d.data)->revision >= 7);
QList<QByteArray> list;
int argc = parameterCount(); int argc = parameterCount();
QList<QByteArray> list;
list.reserve(argc);
int paramsIndex = parametersDataIndex(); int paramsIndex = parametersDataIndex();
for (int i = 0; i < argc; ++i) for (int i = 0; i < argc; ++i)
list += typeNameFromTypeInfo(mobj, mobj->d.data[paramsIndex + i]); list += typeNameFromTypeInfo(mobj, mobj->d.data[paramsIndex + i]);
@ -1682,8 +1683,9 @@ QList<QByteArray> QMetaMethodPrivate::parameterTypes() const
QList<QByteArray> QMetaMethodPrivate::parameterNames() const QList<QByteArray> QMetaMethodPrivate::parameterNames() const
{ {
Q_ASSERT(priv(mobj->d.data)->revision >= 7); Q_ASSERT(priv(mobj->d.data)->revision >= 7);
QList<QByteArray> list;
int argc = parameterCount(); int argc = parameterCount();
QList<QByteArray> list;
list.reserve(argc);
int namesIndex = parametersDataIndex() + argc; int namesIndex = parametersDataIndex() + argc;
for (int i = 0; i < argc; ++i) for (int i = 0; i < argc; ++i)
list += stringData(mobj, mobj->d.data[namesIndex + i]); list += stringData(mobj, mobj->d.data[namesIndex + i]);