AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QAuthenticator: replace split with tokenize

Browse Source 
to avoid needless allocations

Change-Id: I39eb90ef073db5359e7a559e33233b1e75b7461c
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Anton Kudryavtsev 2023-08-25 19:12:44 +03:00
parent 3273c03b51
commit d253156687
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/network/kernel/qauthenticator.cpp
View File

@ -651,6 +651,15 @@ QByteArray QAuthenticatorPrivate::calculateResponse(QByteArrayView requestMethod
// ---------------------------- Digest Md5 code ----------------------------------------
static bool containsAuth(QByteArrayView data)
{
for (auto element : QLatin1StringView(data).tokenize(','_L1)) {
if (element == "auth"_L1)
return true;
}
return false;
}
QHash<QByteArray, QByteArray>
QAuthenticatorPrivate::parseDigestAuthenticationChallenge(QByteArrayView challenge)
{
@ -700,8 +709,7 @@ QAuthenticatorPrivate::parseDigestAuthenticationChallenge(QByteArrayView challen
QByteArray qop = options.value("qop");
if (!qop.isEmpty()) {
QList<QByteArray> qopoptions = qop.split(',');
if (!qopoptions.contains("auth"))
if (!containsAuth(qop))
return QHash<QByteArray, QByteArray>();
// #### can't do auth-int currently
// if (qop.contains("auth-int"))