AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qnetworkcookie: reduce allocations

Browse Source 
Use CaseInsensitive compare more.
While touching code, replcace QBA literal with QBAV

Change-Id: Iecd2740c995f1e24b4285440b9440e4745f93208
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Anton Kudryavtsev 2023-09-01 11:59:07 +03:00
parent 4ee081c2f7
commit d9620f0660
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/network/access/qnetworkcookie.cpp
View File

@ -443,29 +443,33 @@ static QPair<QByteArray, QByteArray> nextField(QByteArrayView text, int &positio
*/
namespace {
QByteArray sameSiteToRawString(QNetworkCookie::SameSite samesite)
constexpr QByteArrayView sameSiteNone() noexcept { return "None"; }
constexpr QByteArrayView sameSiteLax() noexcept { return "Lax"; }
constexpr QByteArrayView sameSiteStrict() noexcept { return "Strict"; }
QByteArrayView sameSiteToRawString(QNetworkCookie::SameSite samesite) noexcept
{
switch (samesite) {
case QNetworkCookie::SameSite::None:
return QByteArrayLiteral("None");
return sameSiteNone();
case QNetworkCookie::SameSite::Lax:
return QByteArrayLiteral("Lax");
return sameSiteLax();
case QNetworkCookie::SameSite::Strict:
return QByteArrayLiteral("Strict");
return sameSiteStrict();
case QNetworkCookie::SameSite::Default:
break;
}
return QByteArray();
return QByteArrayView();
}
QNetworkCookie::SameSite sameSiteFromRawString(QByteArray str)
QNetworkCookie::SameSite sameSiteFromRawString(QByteArrayView str) noexcept
{
str = str.toLower();
if (str == QByteArrayLiteral("none"))
if (str.compare(sameSiteNone(), Qt::CaseInsensitive) == 0)
return QNetworkCookie::SameSite::None;
if (str == QByteArrayLiteral("lax"))
if (str.compare(sameSiteLax(), Qt::CaseInsensitive) == 0)
return QNetworkCookie::SameSite::Lax;
if (str == QByteArrayLiteral("strict"))
if (str.compare(sameSiteStrict(), Qt::CaseInsensitive) == 0)
return QNetworkCookie::SameSite::Strict;
return QNetworkCookie::SameSite::Default;
}