AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid confusing method overloading in QTestTable.

Browse Source 
The private class had two append() methods, one appending a column and
one appending a row.  Use more meaningful names instead of overloading
orthogonal operations.

Change-Id: I97e0268d6cb289694557846f244fe770cf980aaf
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
This commit is contained in:
Jason McDonald 2011-12-16 14:01:12 +10:00 committed by Qt by Nokia
parent f1f500b9aa
commit e299832dbf
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/testlib/qtesttable.cpp
View File

@ -73,8 +73,8 @@ public:
ElementList *list;
DataList *dataList;
void append(int elemType, const char *elemName);
void append(QTestData *data);
void addColumn(int elemType, const char *elemName);
void addRow(QTestData *data);
ElementList *elementAt(int index);
QTestData *dataAt(int index);
@ -124,7 +124,7 @@ QTestTablePrivate::~QTestTablePrivate()
}
}
void QTestTablePrivate::append(int elemType, const char *elemName)
void QTestTablePrivate::addColumn(int elemType, const char *elemName)
{
ElementList *item = new ElementList;
item->elementName = elemName;
@ -139,7 +139,7 @@ void QTestTablePrivate::append(int elemType, const char *elemName)
last->next = item;
}
void QTestTablePrivate::append(QTestData *data)
void QTestTablePrivate::addRow(QTestData *data)
{
DataList *item = new DataList;
item->data = data;
@ -158,7 +158,7 @@ void QTestTable::addColumn(int type, const char *name)
QTEST_ASSERT(type);
QTEST_ASSERT(name);
d->append(type, name);
d->addColumn(type, name);
}
int QTestTable::elementCount() const
@ -192,7 +192,7 @@ bool QTestTable::isEmpty() const
QTestData *QTestTable::newData(const char *tag)
{
QTestData *dt = new QTestData(tag, this);
d->append(dt);
d->addRow(dt);
return dt;
}