From e83c9e4e8e74c57708fa88ee441584eee18f19b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Thu, 3 Mar 2022 18:29:32 +0100 Subject: [PATCH] QAbstractSocket: update setSocketOption documentation Specify that it should not be called until the internal socket engine has been created. Given that most usages of this function will be on QUdpSockets and that people will likely want to call bind() on those anyway, we just document this rather than implement some caching mechanism. Pick-to: 6.3 6.2 Fixes: QTBUG-67576 Change-Id: Ia5d3ade95460b7c5685681ee098f1c00bff43a90 Reviewed-by: Timur Pocheptsov Reviewed-by: Edward Welbourne Reviewed-by: Thiago Macieira --- src/network/socket/qabstractsocket.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/network/socket/qabstractsocket.cpp b/src/network/socket/qabstractsocket.cpp index fc0e4ad783..53ef298d76 100644 --- a/src/network/socket/qabstractsocket.cpp +++ b/src/network/socket/qabstractsocket.cpp @@ -1946,6 +1946,10 @@ bool QAbstractSocket::setSocketDescriptor(qintptr socketDescriptor, SocketState \since 4.6 Sets the given \a option to the value described by \a value. + \note Since the options are set on an internal socket the options + only apply if the socket has been created. This is only guaranteed to + have happened after a call to bind(), or when connected() has been emitted. + \sa socketOption() */ void QAbstractSocket::setSocketOption(QAbstractSocket::SocketOption option, const QVariant &value)