AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cache QUrl::idnWhiteList() absent user_idn_whitelist

Browse Source 
Instead of creating a QStringList from a static array anew for each
call, cache the result in a static variable. If we have to pay for the
overhead of implicitly-shared classes, we should at least reap the
benefits, too.

Use IILE to gain automatic thread-safety (thread-safe statics).

Change-Id: Ib92dd9cb85f84e013f98ca81565cc392bb39e76b
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
This commit is contained in:
Marc Mutz 2020-05-11 17:15:25 +02:00
parent 565c2e8cf9
commit ed4c1b4e90
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/corelib/io/qurlidna.cpp
View File

@ -2605,13 +2605,16 @@ QStringList QUrl::idnWhitelist()
{ {
if (user_idn_whitelist) if (user_idn_whitelist)
return *user_idn_whitelist; return *user_idn_whitelist;
QStringList list; static const QStringList list = [] {
list.reserve(idn_whitelist_size); QStringList list;
unsigned int i = 0; list.reserve(idn_whitelist_size);
while (i < idn_whitelist_size) { unsigned int i = 0;
list << QLatin1String(idn_whitelist[i]); while (i < idn_whitelist_size) {
++i; list << QLatin1String(idn_whitelist[i]);
} ++i;
}
return list;
}();
return list; return list;
} }