AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix QSystemTrayIcon stale pointer access

Browse Source 
The child imageCell is a NSView and may be retained by Cocoa,
which means it may outlive the parent QNSStatusItem.

Clear its parent pointer to avoid referencing a stale
pointer.

Task-number: QTBUG-47929
Change-Id: I6078070b8c9f512ecd034fee4e54b1d8282dabdf
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
This commit is contained in:
Morten Johan Sørvig 2018-12-12 14:59:48 +01:00
parent fb67ac6368
commit f0dd6655e1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/platforms/cocoa/qcocoasystemtrayicon.mm
View File

@ -372,6 +372,7 @@ QT_END_NAMESPACE
- (void)dealloc { - (void)dealloc {
[[NSStatusBar systemStatusBar] removeStatusItem:item]; [[NSStatusBar systemStatusBar] removeStatusItem:item];
[[NSNotificationCenter defaultCenter] removeObserver:imageCell]; [[NSNotificationCenter defaultCenter] removeObserver:imageCell];
imageCell.parent = nil;
[imageCell release]; [imageCell release];
[item release]; [item release];
[super dealloc]; [super dealloc];