From f2f5e962b6c9e9b146bb4cf24fa93f7207884dca Mon Sep 17 00:00:00 2001 From: Fabian Kosmale Date: Sun, 11 Oct 2020 10:31:10 +0200 Subject: [PATCH] QUntypedPropertyBinding::QUntypedPropertyBinding: use member initializer list No need to default initialize the std::function and source location. Change-Id: I7d840376b16e7257386a4787dd06b7956fe37576 Reviewed-by: Ulf Hermann --- src/corelib/kernel/qproperty.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/kernel/qproperty.cpp b/src/corelib/kernel/qproperty.cpp index d25952c0bf..c742e2194a 100644 --- a/src/corelib/kernel/qproperty.cpp +++ b/src/corelib/kernel/qproperty.cpp @@ -142,8 +142,8 @@ QUntypedPropertyBinding::QUntypedPropertyBinding() = default; QUntypedPropertyBinding::QUntypedPropertyBinding(QMetaType metaType, QUntypedPropertyBinding::BindingEvaluationFunction function, const QPropertyBindingSourceLocation &location) + : d(new QPropertyBindingPrivate(metaType, std::move(function), std::move(location))) { - d = new QPropertyBindingPrivate(metaType, std::move(function), std::move(location)); } QUntypedPropertyBinding::QUntypedPropertyBinding(QUntypedPropertyBinding &&other)