AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QFutureSynchronizer: mark ctors [[nodiscard]]

Browse Source 
QFutureSynchronizer is a RAII class. QUIP-0019 says that RAII class
ctors should be marked as [[nodiscard]].

Pick-to: 6.6
Task-number: QTBUG-104164
Change-Id: I0b6710f2b9a14d67f64150f240f819b8336e0929
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
This commit is contained in:
Marc Mutz 2023-06-21 11:45:50 +02:00
parent e8dcbaaaf6
commit f403ef428e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/corelib/thread/qfuturesynchronizer.h
View File

@ -17,7 +17,8 @@ class QFutureSynchronizer
Q_DISABLE_COPY(QFutureSynchronizer)
public:
QFutureSynchronizer() : m_cancelOnWait(false) { }
Q_NODISCARD_CTOR QFutureSynchronizer() : m_cancelOnWait(false) { }
Q_NODISCARD_CTOR
explicit QFutureSynchronizer(QFuture<T> future)
: m_cancelOnWait(false)
{ addFuture(std::move(future)); }