00b4bd0a42
The comment to the code said it was to avoid double click. However it actually breaks wanted double clicks. The reason for it must be that the replayed event in earlier code versions could be changed into a double click (together with the first event). However (now) we only test qt_replay_popup_mouse_event in void QWidgetWindow::handleMouseEvent(QMouseEvent *event); Regardless what kind of event we receive as input it will send QEvent::MouseButtonPress when it sends replay mouse event. I.e. it will then call QCoreApplication::sendSpontaneousEvent(r,e) => QCoreApplication::notifyInternal(receiver, event) => QCoreApplication::notify(receiver, event) => QApplicationPrivate::notify_helper(receiver, event) (+filters) => (probably) QWidgeWindow::event(receiver, event) => further handling in widget classes. That especially means that it will *not* get into the function QGuiApplicationPrivate::processMouseEvent where doubleclicks are created. Therefore no doubleclick can be made from the extra event. That makes the statement have no good effect - just side effects. Change-Id: I190baff3c060548775201695e324059560bb7106 Reviewed-by: Samuel Rødal <samuel.rodal@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com> |
||
---|---|---|
bin | ||
config.tests | ||
dist | ||
doc | ||
examples | ||
lib | ||
mkspecs | ||
qmake | ||
src | ||
tests | ||
tools | ||
util | ||
.gitattributes | ||
.gitignore | ||
.qmake.conf | ||
.tag | ||
configure | ||
configure.bat | ||
header.BSD | ||
header.FDL | ||
header.LGPL | ||
header.LGPL-ONLY | ||
INSTALL | ||
LGPL_EXCEPTION.txt | ||
LICENSE.FDL | ||
LICENSE.GPL | ||
LICENSE.LGPL | ||
LICENSE.PREVIEW.COMMERCIAL | ||
qtbase.pro | ||
sync.profile |