qt5base-lts/coin/instructions
Alexandru Croitor b0824ad931 coin: Preserve quoted arguments when calling cmake / configure
Previously we used sh $* for passing parameters of various calls like
cmake / configure. This did not properly preserve quoted arguments,
leading to potential issues.

For example when configuring qtbase with

 cmake -DQT_QMAKE_DEVICE_OPTIONS="DISTRO_OPTS=hard-float boot2qt"

the 'boot2qt' option would be passed as a separate argument to cmake,
leading to the QT_QMAKE_DEVICE_OPTIONS cache var containing only
'DISTRO_OPTS=hard-float'.

Use "$@" to preserve the quotes.

Inspired by
https://wiki.bash-hackers.org/scripting/posparams#all_positional_parameters

Amends e9b8837c31

Pick-to: 6.2 6.3
Change-Id: Ib67d4bc138c65f7430457cb2a2baa55bff72e549
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
2022-03-11 02:43:46 +01:00
..
qmake CMake: Build examples with qmake against a CMake built Qt 2020-12-04 15:39:32 +01:00
qmake_examples CMake: Build examples with qmake against a CMake built Qt 2020-12-04 15:39:32 +01:00
call_cmake_for_standalone_tests.yaml Move bin/qt-internal-configure-tests to libexec 2021-03-30 14:39:12 +01:00
call_cmake.yaml CMake: Use the same generator when building other repositories 2020-05-19 10:16:16 +02:00
call_host_cmake.yaml CMake: Use the same generator when building other repositories 2020-05-19 10:16:16 +02:00
call_host_install.yaml CMake: Use custom install script to support Ninja Multi-Config builds 2020-05-19 10:16:11 +02:00
call_target_cmake.yaml CMake: Use the same generator when building other repositories 2020-05-19 10:16:16 +02:00
call_target_install.yaml CMake: Use custom install script to support Ninja Multi-Config builds 2020-05-19 10:16:11 +02:00
cmake_build_and_upload_test_artifacts_host.yaml Read test specific configure arguments from environment 2020-09-28 05:28:22 +00:00
cmake_build_and_upload_test_artifacts_target.yaml Read test specific configure arguments from environment 2020-09-28 05:28:22 +00:00
cmake_build_and_upload_test_artifacts.yaml coin: Move AUTOGEN and tests options addition into a common location 2022-01-19 01:28:02 +01:00
cmake_cross_compilation_module_build_instructions.yaml coin: Move AUTOGEN and tests options addition into a common location 2022-01-19 01:28:02 +01:00
cmake_cross_compilation_qtbase_build_instructions.yaml Coin: use CMAKE_STAGING_PREFIX for cross-compilations 2022-01-20 10:07:04 +02:00
cmake_documentation_build.yaml Build docs in-tree 2021-11-12 16:44:22 +00:00
cmake_module_build_instructions.yaml coin: Move AUTOGEN and tests options addition into a common location 2022-01-19 01:28:02 +01:00
cmake_qtbase_build_instructions.yaml coin: Move AUTOGEN and tests options addition into a common location 2022-01-19 01:28:02 +01:00
cmake_regular_test_instructions_common.yaml Coin: remove workarounds to allow running Android tests 2021-02-18 13:42:19 +02:00
cmake_regular_test_instructions_enforced.yaml CMake: Build minimal subset of tests in desktop static builds 2021-04-06 09:15:37 +01:00
cmake_regular_test_instructions.yaml CMake: Add support for enforcing passing CI tests per repository 2020-07-03 11:14:11 +02:00
cmake_run_ctest_enforce_exit_code.yaml Clean up QNX platform configs and improve testrunner scripts 2022-02-14 12:56:06 +01:00
cmake_run_ctest_ignore_exit_code.yaml Increase the timeout for test targets 2021-06-02 21:02:41 +03:00
cmake_setup_running_qnxqemu_tests_env_vars.yaml Clean up QNX platform configs and improve testrunner scripts 2022-02-14 12:56:06 +01:00
cmake_setup_running_tests_env_vars.yaml Introduce qt-testrunner.py 2022-01-03 16:32:56 +01:00
coin_module_build_template_v2.yaml CI: Enable rest of the Qt modules for QNX 2021-12-14 10:41:56 +02:00
coin_module_test_android_start_emulator.yaml Properly wait for the Android emulator to fully boot 2022-01-07 19:34:50 +01:00
coin_module_test_docs.yaml coin: Add instructions to generate docs during testing 2021-10-18 16:23:13 +00:00
coin_module_test_qemu_env_vars.yaml CMake: Add instructions for building and testing qemu configs 2020-06-25 14:11:56 +02:00
coin_module_test_qnx_start_emulator.yaml CI: Increase timeout for waiting QNX qemu to start 2022-03-09 22:38:16 +02:00
coin_module_test_template_common.yaml CI: Add QNX qemu support 2021-10-27 13:30:01 +03:00
coin_module_test_template_v2.yaml CI: Enable building autotests for QNX QEMU 2021-10-27 10:30:02 +00:00
coin_module_test_template_v3.yaml CI: Enable building autotests for QNX QEMU 2021-10-27 10:30:02 +00:00
coin_qtbase_build_template_v2.yaml Turn on autotest build for INTEGRITY on CI 2021-12-01 22:48:49 +02:00
coin_qtbase_test_docs.yaml coin: Add instructions to generate docs during testing 2021-10-18 16:23:13 +00:00
prepare_building_env.yaml coin: Preserve quoted arguments when calling cmake / configure 2022-03-11 02:43:46 +01:00
README.md CMake: Add support for enforcing passing CI tests per repository 2020-07-03 11:14:11 +02:00

Information about Coin instruction templates

Build templates

  • coin_qtbase_build_template_v2.yaml did not exist. The build instructions were directly embedded into module_config.yaml and did not support repos outside of qtbase, also no cross-compilation.
  • coin_qtbase_build_template_v2 introduced support for building other repos, and also enabled build cross-compiling targets like Android and iOS. A bit later the template gained the ability to build qemu cross-compiling configurations. The counterpart to qtbase to build other repositories is coin_module_build_template_v2

Test templates

  • coin_module_test_template_v1 did not exist. The test instructions were directly embedded into module_config.yaml and did not support repos outside of qtbase, also no cross-compilation.
  • coin_module_test_template_v2 introduced support for building tests for other repos, and made sure not to build and run tests on cross-compiling configuration. A bit later the template gained the ability to build and run tests for qemu cross-compiling configurations.
  • coin_module_test_template_v3 changed the run test instructions to not ignore the exit code and thus enforce that tests pass in the CI.