b0824ad931
Previously we used sh $* for passing parameters of various calls like
cmake / configure. This did not properly preserve quoted arguments,
leading to potential issues.
For example when configuring qtbase with
cmake -DQT_QMAKE_DEVICE_OPTIONS="DISTRO_OPTS=hard-float boot2qt"
the 'boot2qt' option would be passed as a separate argument to cmake,
leading to the QT_QMAKE_DEVICE_OPTIONS cache var containing only
'DISTRO_OPTS=hard-float'.
Use "$@" to preserve the quotes.
Inspired by
https://wiki.bash-hackers.org/scripting/posparams#all_positional_parameters
Amends
|
||
---|---|---|
.. | ||
qmake | ||
qmake_examples | ||
call_cmake_for_standalone_tests.yaml | ||
call_cmake.yaml | ||
call_host_cmake.yaml | ||
call_host_install.yaml | ||
call_target_cmake.yaml | ||
call_target_install.yaml | ||
cmake_build_and_upload_test_artifacts_host.yaml | ||
cmake_build_and_upload_test_artifacts_target.yaml | ||
cmake_build_and_upload_test_artifacts.yaml | ||
cmake_cross_compilation_module_build_instructions.yaml | ||
cmake_cross_compilation_qtbase_build_instructions.yaml | ||
cmake_documentation_build.yaml | ||
cmake_module_build_instructions.yaml | ||
cmake_qtbase_build_instructions.yaml | ||
cmake_regular_test_instructions_common.yaml | ||
cmake_regular_test_instructions_enforced.yaml | ||
cmake_regular_test_instructions.yaml | ||
cmake_run_ctest_enforce_exit_code.yaml | ||
cmake_run_ctest_ignore_exit_code.yaml | ||
cmake_setup_running_qnxqemu_tests_env_vars.yaml | ||
cmake_setup_running_tests_env_vars.yaml | ||
coin_module_build_template_v2.yaml | ||
coin_module_test_android_start_emulator.yaml | ||
coin_module_test_docs.yaml | ||
coin_module_test_qemu_env_vars.yaml | ||
coin_module_test_qnx_start_emulator.yaml | ||
coin_module_test_template_common.yaml | ||
coin_module_test_template_v2.yaml | ||
coin_module_test_template_v3.yaml | ||
coin_qtbase_build_template_v2.yaml | ||
coin_qtbase_test_docs.yaml | ||
prepare_building_env.yaml | ||
README.md |
Information about Coin instruction templates
Build templates
coin_qtbase_build_template_v2.yaml
did not exist. The build instructions were directly embedded intomodule_config.yaml
and did not support repos outside of qtbase, also no cross-compilation.coin_qtbase_build_template_v2
introduced support for building other repos, and also enabled build cross-compiling targets likeAndroid
andiOS
. A bit later the template gained the ability to buildqemu
cross-compiling configurations. The counterpart to qtbase to build other repositories iscoin_module_build_template_v2
Test templates
coin_module_test_template_v1
did not exist. The test instructions were directly embedded intomodule_config.yaml
and did not support repos outside of qtbase, also no cross-compilation.coin_module_test_template_v2
introduced support for building tests for other repos, and made sure not to build and run tests on cross-compiling configuration. A bit later the template gained the ability to build and run tests forqemu
cross-compiling configurations.coin_module_test_template_v3
changed the run test instructions to not ignore the exit code and thus enforce that tests pass in the CI.