qt5base-lts

History

Simon Hausmann 12eb3b51c4 Fix incorrect repaints with plain text edit The plain text edit's smart repaint logic in QPlainTextDocumentLayout::documentChanged assumes that during a change inside just one block, the block is in the state before the edit and a call to layoutBlock() is going to bring it up-to-date. Then only a comparison of the bounding rect - before and after - is going to allow for smart repaints. The assumption of the layout being in the same state as before the edit got broken by commit `cc57a2e90f`, which introduced code to use a QTextCursor within a slot connected to QTextDocument's contentsChange signal. The usage of the QTextCursor there ends up updating the layout of the block ahead of time, breaking the assumption and therefore the optimization, in the sense that during changes in the preedit that cause a change of height / line count, the old bounding rect in QPlainTextDocumentLayout::documentChanged and the new bounding rect will be the same. This causes a repaint of only the edited block, missing repaints of the following blocks, even though the line count effectively changed. So what's causing QTextCursor to mess with the layout is the attempt of updating the vertical movement x property. This patch inhibits the update, marking it as dirty for initialization later. This means that slots connected to this low-level signal cannot rely on the cursor's visual x position, but that doesn't seem useful anyway and isn't required for commit `cc57a2e90f`. Task-number: QTBUG-38536 Change-Id: I5fae12d646a4b2d2cc22b9f2d021e5dc8cfdda94 Reviewed-by: Paul Olav Tvete <paul.tvete@digia.com> Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com> Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>		2014-04-30 18:23:23 +02:00
..
auto	Fix incorrect repaints with plain text edit	2014-04-30 18:23:23 +02:00
baselineserver	WinRT: Fix various test compilations	2013-10-02 12:36:05 +02:00
benchmarks	Add a benchmark test for QCryptographicHash	2014-04-04 01:29:37 +02:00
global	tst_bic: Add linux-gcc-ia32 bic data for QtXml	2013-01-16 08:25:28 +01:00
manual	OSX: add several menuitem roles to support menu shortcuts in dialogs	2014-04-07 08:30:24 +02:00
shared	Use a fake directory model instead of QDirModel in item view tests.	2014-01-27 15:40:17 +01:00
README	Doc: Fix references to Qt Test	2013-01-30 01:35:06 +01:00
tests.pro	iOS: Enable building of basic tests	2014-01-22 12:35:17 +01:00

README

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.