980795dc55
The platform plugins are implemented to grab the entire screen if no window ID is provided. They do not grab the entire virtual screen, just the screen the method is called on. On macOS, the implementation ignored the window parameter, and always grabbed the entire virtual screen. This change fixes the cocoa implementation. The test passes in local tests (with two displays with different dpr). Since grabbing a screen returns an image with managed colors, we need to convert it to sRGB color spec first, otherwise displaying a grabbed image will produce different results. This will need to be changed once Qt supports a fully color managed flow. The test does not cover the case where a window spans multiple displays, since this is generally not supported at least on macOS. The code that exists in QCocoaScreen to handle that case is untested, but with the exception of the optimization it is also unchanged. Done-with: Morten Sørvig <morten.sorvig@qt.io> Change-Id: I8ac1233e56d559230ff9e10111abfb6227431e8c Fixes: QTBUG-84876 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
340 lines
13 KiB
C++
340 lines
13 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of the test suite of the Qt Toolkit.
|
|
**
|
|
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
** $QT_END_LICENSE$
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include <qpainter.h>
|
|
#include <qrasterwindow.h>
|
|
#include <qscreen.h>
|
|
#include <qpa/qwindowsysteminterface.h>
|
|
|
|
#include <QtTest/QtTest>
|
|
|
|
class tst_QScreen: public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void angleBetween_data();
|
|
void angleBetween();
|
|
void transformBetween_data();
|
|
void transformBetween();
|
|
void orientationChange();
|
|
|
|
void grabWindow_data();
|
|
void grabWindow();
|
|
};
|
|
|
|
void tst_QScreen::angleBetween_data()
|
|
{
|
|
QTest::addColumn<uint>("oa");
|
|
QTest::addColumn<uint>("ob");
|
|
QTest::addColumn<int>("expected");
|
|
|
|
QTest::newRow("Portrait Portrait")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< 0;
|
|
|
|
QTest::newRow("Portrait Landscape")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< 270;
|
|
|
|
QTest::newRow("Portrait InvertedPortrait")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::InvertedPortraitOrientation)
|
|
<< 180;
|
|
|
|
QTest::newRow("Portrait InvertedLandscape")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< 90;
|
|
|
|
QTest::newRow("InvertedLandscape InvertedPortrait")
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< uint(Qt::InvertedPortraitOrientation)
|
|
<< 90;
|
|
|
|
QTest::newRow("InvertedLandscape Landscape")
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< 180;
|
|
|
|
QTest::newRow("Landscape Primary")
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< uint(Qt::PrimaryOrientation)
|
|
<< QGuiApplication::primaryScreen()->angleBetween(Qt::LandscapeOrientation, QGuiApplication::primaryScreen()->primaryOrientation());
|
|
}
|
|
|
|
void tst_QScreen::angleBetween()
|
|
{
|
|
QFETCH( uint, oa );
|
|
QFETCH( uint, ob );
|
|
QFETCH( int, expected );
|
|
|
|
Qt::ScreenOrientation a = Qt::ScreenOrientation(oa);
|
|
Qt::ScreenOrientation b = Qt::ScreenOrientation(ob);
|
|
|
|
QCOMPARE(QGuiApplication::primaryScreen()->angleBetween(a, b), expected);
|
|
QCOMPARE(QGuiApplication::primaryScreen()->angleBetween(b, a), (360 - expected) % 360);
|
|
}
|
|
|
|
void tst_QScreen::transformBetween_data()
|
|
{
|
|
QTest::addColumn<uint>("oa");
|
|
QTest::addColumn<uint>("ob");
|
|
QTest::addColumn<QRect>("rect");
|
|
QTest::addColumn<QTransform>("expected");
|
|
|
|
QRect rect(0, 0, 480, 640);
|
|
|
|
QTest::newRow("Portrait Portrait")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< rect
|
|
<< QTransform();
|
|
|
|
QTest::newRow("Portrait Landscape")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< rect
|
|
<< QTransform(0, -1, 1, 0, 0, rect.height());
|
|
|
|
QTest::newRow("Portrait InvertedPortrait")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::InvertedPortraitOrientation)
|
|
<< rect
|
|
<< QTransform(-1, 0, 0, -1, rect.width(), rect.height());
|
|
|
|
QTest::newRow("Portrait InvertedLandscape")
|
|
<< uint(Qt::PortraitOrientation)
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< rect
|
|
<< QTransform(0, 1, -1, 0, rect.width(), 0);
|
|
|
|
QTest::newRow("InvertedLandscape InvertedPortrait")
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< uint(Qt::InvertedPortraitOrientation)
|
|
<< rect
|
|
<< QTransform(0, 1, -1, 0, rect.width(), 0);
|
|
|
|
QTest::newRow("InvertedLandscape Landscape")
|
|
<< uint(Qt::InvertedLandscapeOrientation)
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< rect
|
|
<< QTransform(-1, 0, 0, -1, rect.width(), rect.height());
|
|
|
|
QTest::newRow("Landscape Primary")
|
|
<< uint(Qt::LandscapeOrientation)
|
|
<< uint(Qt::PrimaryOrientation)
|
|
<< rect
|
|
<< QGuiApplication::primaryScreen()->transformBetween(Qt::LandscapeOrientation, QGuiApplication::primaryScreen()->primaryOrientation(), rect);
|
|
}
|
|
|
|
void tst_QScreen::transformBetween()
|
|
{
|
|
QFETCH( uint, oa );
|
|
QFETCH( uint, ob );
|
|
QFETCH( QRect, rect );
|
|
QFETCH( QTransform, expected );
|
|
|
|
Qt::ScreenOrientation a = Qt::ScreenOrientation(oa);
|
|
Qt::ScreenOrientation b = Qt::ScreenOrientation(ob);
|
|
|
|
QCOMPARE(QGuiApplication::primaryScreen()->transformBetween(a, b, rect), expected);
|
|
}
|
|
|
|
void tst_QScreen::orientationChange()
|
|
{
|
|
qRegisterMetaType<Qt::ScreenOrientation>("Qt::ScreenOrientation");
|
|
|
|
QScreen *screen = QGuiApplication::primaryScreen();
|
|
QSignalSpy spy(screen, SIGNAL(orientationChanged(Qt::ScreenOrientation)));
|
|
int expectedSignalCount = 0;
|
|
|
|
QWindowSystemInterface::handleScreenOrientationChange(screen, Qt::LandscapeOrientation);
|
|
QWindowSystemInterface::flushWindowSystemEvents();
|
|
QTRY_COMPARE(screen->orientation(), Qt::LandscapeOrientation);
|
|
QCOMPARE(spy.count(), ++expectedSignalCount);
|
|
|
|
QWindowSystemInterface::handleScreenOrientationChange(screen, Qt::PortraitOrientation);
|
|
QWindowSystemInterface::flushWindowSystemEvents();
|
|
QTRY_COMPARE(screen->orientation(), Qt::PortraitOrientation);
|
|
QCOMPARE(spy.count(), ++expectedSignalCount);
|
|
|
|
QWindowSystemInterface::handleScreenOrientationChange(screen, Qt::InvertedLandscapeOrientation);
|
|
QWindowSystemInterface::flushWindowSystemEvents();
|
|
QTRY_COMPARE(screen->orientation(), Qt::InvertedLandscapeOrientation);
|
|
QCOMPARE(spy.count(), ++expectedSignalCount);
|
|
|
|
QWindowSystemInterface::handleScreenOrientationChange(screen, Qt::InvertedPortraitOrientation);
|
|
QWindowSystemInterface::flushWindowSystemEvents();
|
|
QTRY_COMPARE(screen->orientation(), Qt::InvertedPortraitOrientation);
|
|
QCOMPARE(spy.count(), ++expectedSignalCount);
|
|
|
|
QWindowSystemInterface::handleScreenOrientationChange(screen, Qt::LandscapeOrientation);
|
|
QWindowSystemInterface::flushWindowSystemEvents();
|
|
QTRY_COMPARE(screen->orientation(), Qt::LandscapeOrientation);
|
|
QCOMPARE(spy.count(), ++expectedSignalCount);
|
|
}
|
|
|
|
void tst_QScreen::grabWindow_data()
|
|
{
|
|
if (QGuiApplication::platformName().startsWith(QLatin1String("offscreen"), Qt::CaseInsensitive))
|
|
QSKIP("Offscreen: Screen grabbing not implemented.");
|
|
|
|
QTest::addColumn<int>("screenIndex");
|
|
QTest::addColumn<QByteArray>("screenName");
|
|
QTest::addColumn<bool>("grabWindow");
|
|
QTest::addColumn<QRect>("windowRect");
|
|
QTest::addColumn<QRect>("grabRect");
|
|
|
|
int screenIndex = 0;
|
|
for (const auto screen : QGuiApplication::screens()) {
|
|
const QByteArray screenName = screen->name().toUtf8();
|
|
const QRect availableGeometry = screen->availableGeometry();
|
|
const QPoint topLeft = availableGeometry.topLeft() + QPoint(20, 20);
|
|
QTest::addRow("%s - Window", screenName.data())
|
|
<< screenIndex << screenName << true << QRect(topLeft, QSize(200, 200)) << QRect(0, 0, -1, -1);
|
|
QTest::addRow("%s - Window Section", screenName.data())
|
|
<< screenIndex << screenName << true << QRect(topLeft, QSize(200, 200)) << QRect(50, 50, 100, 100);
|
|
QTest::addRow("%s - Screen", screenName.data())
|
|
<< screenIndex << screenName << false << QRect(topLeft, QSize(200, 200)) << QRect(0, 0, -1, -1);
|
|
QTest::addRow("%s - Screen Section", screenName.data())
|
|
<< screenIndex << screenName << false << QRect(topLeft, QSize(200, 200)) << QRect(topLeft, QSize(200, 200));
|
|
|
|
++screenIndex;
|
|
}
|
|
}
|
|
|
|
void tst_QScreen::grabWindow()
|
|
{
|
|
QFETCH(int, screenIndex);
|
|
QFETCH(QByteArray, screenName);
|
|
QFETCH(bool, grabWindow);
|
|
QFETCH(QRect, windowRect);
|
|
QFETCH(QRect, grabRect);
|
|
|
|
class Window : public QRasterWindow
|
|
{
|
|
public:
|
|
Window(QScreen *scr)
|
|
: image(scr->size(), QImage::Format_ARGB32_Premultiplied)
|
|
{
|
|
setFlags(Qt::CustomizeWindowHint|Qt::FramelessWindowHint|Qt::WindowStaysOnTopHint);
|
|
setScreen(scr);
|
|
image.setDevicePixelRatio(scr->devicePixelRatio());
|
|
}
|
|
QImage image;
|
|
|
|
protected:
|
|
void resizeEvent(QResizeEvent *e) override
|
|
{
|
|
const QSize sz = e->size();
|
|
image = image.scaled(sz * image.devicePixelRatioF());
|
|
QPainter painter(&image);
|
|
painter.fillRect(0, 0, sz.width(), sz.height(), Qt::black);
|
|
painter.setPen(QPen(Qt::red, 2));
|
|
painter.drawLine(0, 0, sz.width(), sz.height());
|
|
painter.drawLine(0, sz.height(), sz.width(), 0);
|
|
painter.drawRect(0, 0, sz.width(), sz.height());
|
|
}
|
|
void paintEvent(QPaintEvent *) override
|
|
{
|
|
QPainter painter(this);
|
|
painter.drawImage(0, 0, image);
|
|
}
|
|
};
|
|
const auto screens = QGuiApplication::screens();
|
|
double highestDpr = 0;
|
|
for (auto screen : screens)
|
|
highestDpr = qMax(highestDpr, screen->devicePixelRatio());
|
|
|
|
QScreen *screen = screens.at(screenIndex);
|
|
QCOMPARE(screen->name().toUtf8(), screenName);
|
|
const double screenDpr = screen->devicePixelRatio();
|
|
|
|
Window window(screen);
|
|
window.setGeometry(windowRect);
|
|
window.show();
|
|
|
|
if (!QTest::qWaitForWindowExposed(&window))
|
|
QSKIP("Failed to expose window - aborting");
|
|
|
|
if (QGuiApplication::platformName().startsWith(QLatin1String("xcb"), Qt::CaseInsensitive))
|
|
QTest::qWait(1500); // this is ridiculously necessary because of effects combined with slowness of VMs
|
|
#ifdef Q_OS_MACOS // wait for desktop on screen to scroll into place
|
|
QTest::qWait(1000);
|
|
#endif
|
|
|
|
QSize expectedGrabSize = grabRect.isValid() ? grabRect.size() : (grabWindow ? windowRect.size() : screen->size());
|
|
// we ask for pixel coordinates, but will get a pixmap with device-specific DPR
|
|
expectedGrabSize *= screen->devicePixelRatio();
|
|
|
|
// the painted image will always be in the screen's DPR
|
|
QImage paintedImage = window.image;
|
|
QCOMPARE(paintedImage.devicePixelRatio(), screenDpr);
|
|
|
|
const QPixmap pixmap = screen->grabWindow(grabWindow ? window.winId() : 0, grabRect.x(), grabRect.y(), grabRect.width(), grabRect.height());
|
|
|
|
QImage grabbedImage = pixmap.toImage();
|
|
const QSize grabbedSize = grabbedImage.size();
|
|
QCOMPARE(grabbedSize, expectedGrabSize);
|
|
|
|
QPoint pixelOffset = QPoint(0, 0);
|
|
if (!grabRect.isValid()) {
|
|
if (grabWindow) {
|
|
// if we grab the entire window, then the grabbed image should be as large as the window
|
|
QCOMPARE(grabbedImage.size(), paintedImage.size());
|
|
} else {
|
|
// if we grab the entire screen, then the grabbed image should be as large as the screen
|
|
QCOMPARE(grabbedImage.size(), screen->size() * screenDpr);
|
|
pixelOffset = window.geometry().topLeft() - screen->geometry().topLeft();
|
|
grabbedImage = grabbedImage.copy(QRect(pixelOffset * screenDpr, window.geometry().size() * screenDpr));
|
|
}
|
|
} else if (grabWindow) {
|
|
// if we grab the section, compare with the corresponding section from the painted image
|
|
const QRect sectionRect = QRect(grabRect.topLeft() * screenDpr,
|
|
grabRect.size() * screenDpr);
|
|
paintedImage = paintedImage.copy(sectionRect);
|
|
}
|
|
QCOMPARE(grabbedImage.size(), paintedImage.size());
|
|
|
|
// the two images might differ in format, or DPR, so instead of comparing them, sample a few pixels
|
|
for (auto point : {
|
|
QPoint(0, 0),
|
|
QPoint(5, 15),
|
|
QPoint(paintedImage.width() - 1, paintedImage.height() - 1),
|
|
QPoint(paintedImage.width() - 5, paintedImage.height() - 10)
|
|
}) {
|
|
QCOMPARE(grabbedImage.pixelColor(point), paintedImage.pixelColor(point));
|
|
}
|
|
}
|
|
|
|
#include <tst_qscreen.moc>
|
|
QTEST_MAIN(tst_QScreen);
|