qt5base-lts/tests/baseline/stylesheet/tst_baseline_stylesheet.cpp
Volker Hilsheimer 2b99a71b22 Stylesheet: Don't ignore item check indicator styling
Amends cf52d725156811754cd4e094b0984864795d1d58, after which most
indicator styling was no longer taken into account unless some other
item aspects were styled. Calling the baseStyle to draw the entire item
doesn't call back into the style sheet style for the indicator itself.

The QCommonStyle code that breaks the item up into individual sub
elements cannot be called for each element. E.g. turning off the check
indicator feature changes the layout of the item.

So if the indicator is styled, then we have to draw an otherwise empty
item with the style sheet style, and then clip the already painted rect
before calling the base style to draw text and highlighting with the
correct palette.

Add baseline test for QTreeView with different style sheets.

Fixes: QTBUG-102820
Pick-to: 6.3 6.2
Change-Id: I1da5676cc63556230eac525bc550457ebd495a58
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2022-05-06 03:48:09 +02:00

233 lines
7.3 KiB
C++

/****************************************************************************
**
** Copyright (C) 2021 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <qbaselinetest.h>
#include <qwidgetbaselinetest.h>
#include <QtWidgets>
#include <QByteArray>
class tst_Stylesheet : public QWidgetBaselineTest
{
Q_OBJECT
public:
tst_Stylesheet();
void loadTestFiles();
void doInit() override;
private slots:
void tst_QToolButton_data();
void tst_QToolButton();
void tst_QScrollArea_data();
void tst_QScrollArea();
void tst_QTreeView_data();
void tst_QTreeView();
private:
QDir styleSheetDir;
};
tst_Stylesheet::tst_Stylesheet()
{
QString baseDir = QFINDTESTDATA("qss/default.qss");
styleSheetDir = QDir(QFileInfo(baseDir).path());
}
void tst_Stylesheet::doInit()
{
QFETCH(QString, styleSheet);
testWindow()->setStyleSheet(styleSheet);
}
void tst_Stylesheet::loadTestFiles()
{
QTest::addColumn<QString>("styleSheet");
QStringList qssFiles;
// first add generic test files
for (const auto &qssFile : styleSheetDir.entryList({QStringLiteral("*.qss")}, QDir::Files | QDir::Readable))
qssFiles << styleSheetDir.absoluteFilePath(qssFile);
// then test-function specific files
const QString testFunction = QString(QTest::currentTestFunction()).remove("tst_").toLower();
if (styleSheetDir.cd(testFunction)) {
for (const auto &qssFile : styleSheetDir.entryList({QStringLiteral("*.qss")}, QDir::Files | QDir::Readable))
qssFiles << styleSheetDir.absoluteFilePath(qssFile);
styleSheetDir.cdUp();
}
for (const auto &qssFile : qssFiles) {
QFileInfo fileInfo(qssFile);
QFile file(qssFile);
file.open(QFile::ReadOnly);
QString styleSheet = QString::fromUtf8(file.readAll());
QBaselineTest::newRow(fileInfo.baseName().toUtf8()) << styleSheet;
}
}
void tst_Stylesheet::tst_QToolButton_data()
{
loadTestFiles();
}
void tst_Stylesheet::tst_QToolButton()
{
const QIcon trashIcon = QApplication::style()->standardIcon(QStyle::SP_TrashIcon);
QVBoxLayout *vbox = new QVBoxLayout;
QHBoxLayout *normalButtons = new QHBoxLayout;
for (const auto &buttonStyle : {Qt::ToolButtonIconOnly, Qt::ToolButtonTextOnly,
Qt::ToolButtonTextUnderIcon, Qt::ToolButtonTextBesideIcon}) {
QToolButton *normal = new QToolButton;
normal->setToolButtonStyle(buttonStyle);
normal->setText("Norm");
normal->setIcon(trashIcon);
normalButtons->addWidget(normal);
}
vbox->addLayout(normalButtons);
QHBoxLayout *arrowButtons = new QHBoxLayout;
for (const auto &arrowType : {Qt::LeftArrow, Qt::RightArrow, Qt::UpArrow, Qt::DownArrow}) {
QToolButton *arrow = new QToolButton;
arrow->setText("Arrs");
arrow->setArrowType(arrowType);
arrowButtons->addWidget(arrow);
}
vbox->addLayout(arrowButtons);
QHBoxLayout *arrowWithTextButtons = new QHBoxLayout;
for (const auto &buttonStyle : {Qt::ToolButtonTextOnly,
Qt::ToolButtonTextUnderIcon, Qt::ToolButtonTextBesideIcon}) {
QToolButton *arrow = new QToolButton;
arrow->setText("ArrTxt");
arrow->setArrowType(Qt::UpArrow);
arrow->setToolButtonStyle(buttonStyle);
arrowWithTextButtons->addWidget(arrow);
}
vbox->addLayout(arrowWithTextButtons);
QHBoxLayout *menuButtons = new QHBoxLayout;
for (const auto &popupMode : {QToolButton::InstantPopup, QToolButton::MenuButtonPopup,
QToolButton::DelayedPopup}) {
QToolButton *menuButton = new QToolButton;
menuButton->setText("PppMd");
menuButton->setIcon(trashIcon);
QMenu *menuButtonMenu = new QMenu;
menuButtonMenu->addAction(QIcon(":/icons/align-left.png"), "Left");
menuButtonMenu->addAction(QIcon(":/icons/align-right.png"), "Right");
menuButtonMenu->addAction(QIcon(":/icons/align-center.png"), "Center");
menuButton->setMenu(menuButtonMenu);
menuButton->setPopupMode(popupMode);
menuButtons->addWidget(menuButton);
}
vbox->addLayout(menuButtons);
testWindow()->setLayout(vbox);
makeVisible();
QBASELINE_TEST(takeSnapshot());
}
void tst_Stylesheet::tst_QScrollArea_data()
{
loadTestFiles();
}
void tst_Stylesheet::tst_QScrollArea()
{
QHBoxLayout *layout = new QHBoxLayout;
QTableWidget *table = new QTableWidget(20, 20);
layout->addWidget(table);
testWindow()->setLayout(layout);
makeVisible();
QBASELINE_TEST(takeSnapshot());
}
void tst_Stylesheet::tst_QTreeView_data()
{
loadTestFiles();
}
void tst_Stylesheet::tst_QTreeView()
{
QHBoxLayout *layout = new QHBoxLayout;
QTreeWidget *tw = new QTreeWidget();
tw->header()->hide();
layout->addWidget(tw);
for (int i = 0; i < 6; ++i) {
QTreeWidgetItem *topLevelItem = new QTreeWidgetItem(tw, QStringList{QString("top %1").arg(i)});
switch (i) {
case 0:
case 3:
topLevelItem->setCheckState(0, Qt::Unchecked);
break;
case 1:
case 4:
topLevelItem->setCheckState(0, Qt::Checked);
break;
case 2:
case 5:
topLevelItem->setCheckState(0, Qt::PartiallyChecked);
topLevelItem->setExpanded(true);
for (int j = 0; j < 2; ++j) {
QTreeWidgetItem *childItem = new QTreeWidgetItem(topLevelItem, QStringList{QString("child %1").arg(j)});
childItem->setCheckState(0, j % 2 ? Qt::Unchecked : Qt::Checked);
}
break;
}
topLevelItem->setDisabled(i > 2);
}
testWindow()->setLayout(layout);
tw->setRootIsDecorated(true);
makeVisible();
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootDecorated");
tw->setRootIsDecorated(false);
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootNotDecorated");
}
#define main _realmain
QTEST_MAIN(tst_Stylesheet)
#undef main
int main(int argc, char *argv[])
{
qSetGlobalQHashSeed(0); // Avoid rendering variations caused by QHash randomization
QBaselineTest::handleCmdLineArgs(&argc, &argv);
return _realmain(argc, argv);
}
#include "tst_baseline_stylesheet.moc"