Go to file
Marc Mutz 3642d5680d Fix UB (reference to local variable leaving scope) in runOnAndroidMainThread()
The QAndroidApplication::runOnAndroidMainThread() function creates a
task on QThreadPool::globalInstance() to wait for a timeout and cancel
the QFuture representing the task.

It does so by passing a lambda to QThreadPool::start(std::function)
that captures the future, a local variable, by reference. This is UB
when the lambda is ever executed, because the local stack variable's
lifetime will have ended.

To fix, simply capture the future by value, not by reference. Since
QFuture::cancel() is not const, we need to make the lambda mutable.

Fixes: QTBUG-109586
Pick-to: 6.5 6.4 6.2
Change-Id: Icacfb0dc76bcd3a145f90126f535e7c0f4b5ef6a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
2022-12-23 23:22:58 +01:00
.github/workflows Repair github action workflow 2021-11-10 18:57:33 +01:00
bin Return qt-configure-module to bin/ 2022-12-13 10:02:25 +00:00
cmake wasm: Always use basic password-store=basic in tests 2022-12-16 19:29:09 +01:00
coin Return qt-configure-module to bin/ 2022-12-13 10:02:25 +00:00
config.tests Change the license of all CMakeLists.txt and *.cmake files to BSD 2022-08-23 23:58:42 +02:00
dist Add Qt 6.0.0 changes file 2020-11-16 10:02:08 +02:00
doc Doc: Add margins to all anchors in a translated page 2022-12-12 14:14:22 +00:00
examples examples: port xml examples to new connection style 2022-12-21 22:33:02 +01:00
lib
libexec Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
LICENSES Add license text file for Creative Commons Zero (CC0) 1.0 2022-10-19 12:06:09 +02:00
mkspecs wasm: Fix qmake build 2022-12-09 12:21:54 +01:00
qmake qmake: Document that QMAKE_PRE_LINK does not work with Xcode 2022-12-15 20:23:28 +01:00
src Fix UB (reference to local variable leaving scope) in runOnAndroidMainThread() 2022-12-23 23:22:58 +01:00
tests Add QFileInfo::readSymLink() to read the raw link path 2022-12-23 06:26:44 +01:00
util Bump version to 6.6.0 2022-12-14 20:19:01 +02:00
.cmake.conf Bump version to 6.6.0 2022-12-14 20:19:01 +02:00
.gitattributes Give batch files CRLF line endings 2020-11-04 15:02:29 +00:00
.gitignore Assume qhelpgenerator in libexec instead of bin 2021-11-08 19:27:32 +01:00
.lgtm.yml Skip LGTM analysis for the bootstrap library and tools 2020-07-16 01:04:34 +02:00
.tag
CMakeLists.txt Change the license of all CMakeLists.txt and *.cmake files to BSD 2022-08-23 23:58:42 +02:00
conanfile.py Conan: Do not force 'qt_host_path' usage in cross-build context 2022-06-22 18:18:42 +03:00
config_help.txt Update -redo option such that it removes CMakeCache.txt and CMakeFiles/ 2022-12-01 02:23:51 +01:00
configure Update -redo option such that it removes CMakeCache.txt and CMakeFiles/ 2022-12-01 02:23:51 +01:00
configure.bat Update -redo option such that it removes CMakeCache.txt and CMakeFiles/ 2022-12-01 02:23:51 +01:00
configure.cmake Fix clang-cl build with disabled x86 intrinsics 2022-12-15 23:16:04 +01:00
dependencies.yaml
qt_cmdline.cmake QCryptographicHash: implement OpenSSL 3.0 support 2022-09-26 17:26:37 +02:00
sync.profile Move qurltlds_p.h out of src/network, and make it a .cpp file 2022-10-01 06:24:51 +00:00