df9d882d41
This is semantic patch using ClangTidyTransformator:
auto QtContainerClass = expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)
makeRule(cxxMemberCallExpr(on(QtContainerClass),
callee(cxxMethodDecl(hasAnyName({"count", "length"),
parameterCountIs(0))))),
changeTo(cat(access(o, cat("size"), "()"))),
cat("use 'size()' instead of 'count()/length()'"))
a.k.a qt-port-to-std-compatible-api with config Scope: 'Container'.
<classes> are:
// sequential:
"QByteArray",
"QList",
"QQueue",
"QStack",
"QString",
"QVarLengthArray",
"QVector",
// associative:
"QHash",
"QMultiHash",
"QMap",
"QMultiMap",
"QSet",
// Qt has no QMultiSet
Change-Id: Ibe8837be96e8d30d1846881ecd65180c1bc459af
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
81 lines
2.5 KiB
C++
81 lines
2.5 KiB
C++
// Copyright (C) 2016 The Qt Company Ltd.
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
|
|
|
|
#include <QTest>
|
|
#include <QtSql/QtSql>
|
|
|
|
#include "testsqldriver.h"
|
|
|
|
class tst_QSqlResult : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
tst_QSqlResult();
|
|
|
|
private slots:
|
|
void positionalToNamedBinding();
|
|
void parseOfBoundValues();
|
|
|
|
};
|
|
|
|
tst_QSqlResult::tst_QSqlResult()
|
|
{
|
|
}
|
|
|
|
void tst_QSqlResult::positionalToNamedBinding()
|
|
{
|
|
TestSqlDriver testDriver;
|
|
TestSqlDriverResult result(&testDriver);
|
|
QString query("INSERT INTO MYTABLE (ID, NAME, BIRTH) VALUES(?, ?, ?)");
|
|
QVERIFY(result.savePrepare(query));
|
|
QCOMPARE(result.boundValues().size(), 3);
|
|
}
|
|
|
|
void tst_QSqlResult::parseOfBoundValues()
|
|
{
|
|
TestSqlDriver testDriver;
|
|
TestSqlDriverResult result(&testDriver);
|
|
QVERIFY(result.savePrepare("SELECT :1 AS \":2\""));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT :1 AS ':2'"));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT :1 AS [:2]"));
|
|
if (testDriver.dbmsType() == QSqlDriver::PostgreSQL)
|
|
QCOMPARE(result.boundValues().size(), 2);
|
|
else
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT :1 AS [:2]]]"));
|
|
if (testDriver.dbmsType() == QSqlDriver::PostgreSQL)
|
|
QCOMPARE(result.boundValues().size(), 2);
|
|
else
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT :1 AS [:2]]]]]"));
|
|
if (testDriver.dbmsType() == QSqlDriver::PostgreSQL)
|
|
QCOMPARE(result.boundValues().size(), 2);
|
|
else
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
|
|
QVERIFY(result.savePrepare("SELECT ? AS \"?\""));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT ? AS '?'"));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT ? AS [?]"));
|
|
if (testDriver.dbmsType() == QSqlDriver::PostgreSQL)
|
|
QCOMPARE(result.boundValues().size(), 2);
|
|
else
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
|
|
QVERIFY(result.savePrepare("SELECT ? AS \"'?\""));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT ? AS '?\"'"));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT ? AS '?''?'"));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
QVERIFY(result.savePrepare("SELECT ? AS [\"?']"));
|
|
QCOMPARE(result.boundValues().size(), 1);
|
|
}
|
|
|
|
QTEST_MAIN( tst_QSqlResult )
|
|
#include "tst_qsqlresult.moc"
|