Go to file
Stephen Kelly 43325a23f3 Delete the QVariant ctors taking global Qt enum values.
They have unexpected results in Qt 5 (the Qt::GlobalColor one works
as expected in Qt 4, but was removed in Qt 5):

 QVariant v = QVariant(Qt::red);
 qDebug() << v; // QVariant(int, 7)
 v = Qt::red;
 qDebug() << v; // QVariant(int, 7)

The correct way is to use:

 QVariant v = QVariant::fromValue(QColor(Qt::red));

The deleted constructors are the ones for which there is a class
with an implicit constructor taking the enum, and that class is
a built-in metatype.

QLocale::Language and QKeySequence::StandardKey would also fit
the description, but I can't include the header for QKeySequence
as it is in QtGui, and I don't want to include the qlocale header
in qvariant.h. Putting a QLocale::Language is probably very
uncommon anyway.

The QTextFormat test is doing the wrong thing, but the result isn't
being tested. Added new tests which fail before the patch.

Change-Id: Ia38a0784990f4d40ff7457a86daf58aabd4964eb
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
2012-10-10 08:45:22 +02:00
bin Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
config.tests config.tests/glib: remove app_bundle config (mac compatibility) 2012-10-09 18:00:25 +02:00
dist Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
doc HTML template: Updated copyright information from Nokia to Digia Plc 2012-09-27 02:29:35 +02:00
examples Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
lib Initial import from the monolithic Qt. 2011-04-27 12:05:43 +02:00
mkspecs Generate ';' separated libraries in prl files for CMake. 2012-10-09 06:09:32 +02:00
qmake qmake: fix .pc install target dir separators on windows 2012-10-10 08:45:22 +02:00
src Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
tests Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
tools Use slogger2 for logging on Blackberry instead of writing to stderr 2012-10-04 14:25:47 +02:00
util Update the Unicode Data and Algorithms up to Unicode 6.2 2012-10-09 03:04:41 +02:00
.gitattributes Update the git-archive export options 2012-09-07 15:39:31 +02:00
.gitignore Remove the <module>version.h files from .gitignore. 2012-09-27 23:51:30 +02:00
.tag Update the git-archive export options 2012-09-07 15:39:31 +02:00
configure configure: bump gtk version from 2.10 to 2.18 (sep 2009) 2012-10-08 17:38:02 +02:00
configure.bat Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
header.BSD Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
header.FDL Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
header.LGPL Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
header.LGPL-ONLY Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
INSTALL fix links in INSTALL 2012-10-10 08:45:22 +02:00
LGPL_EXCEPTION.txt Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
LICENSE.FDL Initial import from the monolithic Qt. 2011-04-27 12:05:43 +02:00
LICENSE.GPL Add the LICENSE.GPL file to the module referenced from license headers 2012-05-20 22:41:08 +02:00
LICENSE.LGPL Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
LICENSE.PREVIEW.COMMERCIAL Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
qtbase.pro Use slogger2 for logging on Blackberry instead of writing to stderr 2012-10-04 14:25:47 +02:00
sync.profile Revert "Move QWindowSystemInterface out of qpa." 2012-08-03 00:38:09 +02:00