qt5base-lts

History

Thiago Macieira 4368179c37 QTimer: fix regression on singleShot-invoking non-mormalized SLOT()s The was introduced with the rewrite of QMetaObject::invokeMethod() in commit `0f76e55bc4`, because we have an optimization for zero timers to avoid creating a temporary QSingleShotTimer object. The old implementation did attempt to normalize the target slot name, but did so because it looked metamethods up using QMetaObject::indexOfMethod: int idx = meta->indexOfMethod(sig.constData()); if (idx < 0) { QByteArray norm = QMetaObject::normalizedSignature(sig.constData()); idx = meta->indexOfMethod(norm.constData()); } The new implementation does not use this method so it didn't need to attempt to normalize. I am fixing this only in QTimer and not in QMetaObject::invokeMethodImpl (even though it is trivial to do so) because I don't believe spaces in a pure string to invokeMethod were ever expected to work: QMetaObject::invokeMethod(obj, "slotName ", Qt::QueuedConnection); The Q_ARG and Q_RETURN_ARG (for code not recompiled) still does normalization inside QMetaType::fromName(). Fixes: QTBUG-116060 Pick-to: 6.5 6.6 Change-Id: I964c2b1e6b834feb9710fffd177cac60c83ef413 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>		2023-08-22 10:17:33 -07:00
..
auto	QTimer: fix regression on singleShot-invoking non-mormalized SLOT()s	2023-08-22 10:17:33 -07:00
baseline	Mark all of Qt as free of Q_FOREACH, except where it isn't	2023-08-19 05:19:42 +00:00
benchmarks	Mark all of Qt as free of Q_FOREACH, except where it isn't	2023-08-19 05:19:42 +00:00
global
libfuzzer	Change the license of all CMakeLists.txt and *.cmake files to BSD	2022-08-23 23:58:42 +02:00
manual	Mark all of Qt as free of Q_FOREACH, except where it isn't	2023-08-19 05:19:42 +00:00
shared	Add embeddedwindows manual test	2023-08-07 22:59:19 +02:00
testserver	Use SPDX license identifiers	2022-05-16 16:37:38 +02:00
CMakeLists.txt	Rid of 'special case' markers	2023-04-13 18:30:58 +02:00
README

README

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.