qt5base-lts

History

Jan Kundrát 267ba8b63e QAbstractProxyModel::sibling: treat row/column as offsets within the proxy Qt5 allows QAIM subclasses to reimplement the sibling() method. Unfortunately, the default QAbstractProxyModel's reimplementation differs in behavior to what the Qt4 version was doing. In particular, the Qt4 version used to use the row and column as positions within the proxy model, while the Qt5 version mistakenly does this at the level of source model. This is arguably broken; the caller asks for a sibling of the proxy index, not for a sibling within the proxy model. This change makes the QAPM::sibling work explicitly in the same way as the Qt4 code behaved. The reimplementation of QAbstractProxyModel::sibling was introduced in `9dfba89c28`. It was subsequently fixed with commit `999109866d` not to return indexes from the source model, but the logic was still different from the Qt4 version. [ChangeLog][QtCore][QAbstractProxyModel] Fixed QAbstractProxyModel::sibling to work in the same manner as the Qt4 code used to behave. Previously, Qt5's implementation would treat the row and column as positions in the source model instead of a position in the proxy itself. Followup-to `9dfba89c28` and `999109866d` Change-Id: Ia25027b2ad9e4777ba28de2d2226d48f8cccf587 Reviewed-by: Olivier Goffart <ogoffart@woboq.com> Reviewed-by: Mark Brand <mabrand@mabrand.nl> Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>		2014-05-29 11:11:02 +02:00
..
auto	QAbstractProxyModel::sibling: treat row/column as offsets within the proxy	2014-05-29 11:11:02 +02:00
baselineserver	WinRT: Fix various test compilations	2013-10-02 12:36:05 +02:00
benchmarks	Add a benchmark test for QCryptographicHash	2014-04-04 01:29:37 +02:00
global
manual	QPrinter/Windows: Fix handling of native paper source ids.	2014-05-23 22:18:41 +02:00
shared	Use a fake directory model instead of QDirModel in item view tests.	2014-01-27 15:40:17 +01:00
README	Doc: Fix references to Qt Test	2013-01-30 01:35:06 +01:00
tests.pro	iOS: Enable building of basic tests	2014-01-22 12:35:17 +01:00

README

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.