AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4f65f91d6f
qt5base-lts/tests/auto/dbus/qdbuspendingcall/tst_qdbuspendingcall.cpp
Marc Mutz 1c6bf3e09e Port from container::count() and length() to size() - V5 
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8, but extended to
handle typedefs and accesses through pointers, too:

    const std::string o = "object";

    auto hasTypeIgnoringPointer = [](auto type) { return anyOf(hasType(type), hasType(pointsTo(type))); };

    auto derivedFromAnyOfClasses = [&](ArrayRef<StringRef> classes) {
        auto exprOfDeclaredType = [&](auto decl) {
            return expr(hasTypeIgnoringPointer(hasUnqualifiedDesugaredType(recordType(hasDeclaration(decl))))).bind(o);
        };
        return exprOfDeclaredType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))));
    };

    auto renameMethod = [&] (ArrayRef<StringRef> classes,
                            StringRef from, StringRef to) {
        return makeRule(cxxMemberCallExpr(on(derivedFromAnyOfClasses(classes)),
                            callee(cxxMethodDecl(hasName(from), parameterCountIs(0)))),
                        changeTo(cat(access(o, cat(to)), "()")),
                        cat("use '", to, "' instead of '", from, "'"));
    };

    renameMethod(<classes>, "count", "size");
    renameMethod(<classes>, "length", "size");

except that the on() matcher has been replaced by one that doesn't
ignoreParens().

a.k.a qt-port-to-std-compatible-api V5 with config Scope: 'Container'.

Added two NOLINTNEXTLINEs in tst_qbitarray and tst_qcontiguouscache,
to avoid porting calls that explicitly test count().

Change-Id: Icfb8808c2ff4a30187e9935a51cad26987451c22
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-03 14:59:24 +01:00

456 lines
13 KiB
C++
Raw Blame History

// Copyright (C) 2016 The Qt Company Ltd.
// Copyright (C) 2016 Intel Corporation.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include <QTest>
#include <QTestEventLoop>
#include <QObject>
#include <QVariant>
#include <QList>
#include <QThread>
#include <QDBusAbstractAdaptor>
#include <QDBusMessage>
#include <QDBusConnection>
#include <QDBusPendingCallWatcher>
#include <QDBusInterface>
#define TEST_INTERFACE_NAME "org.qtproject.QtDBus.MyObject"
class MyObject : public QDBusAbstractAdaptor
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.qtproject.QtDBus.MyObject")
public:
MyObject(QObject* parent =0)
: QDBusAbstractAdaptor(parent)
{}
public slots:
QStringList returnFoo() const
{ return QStringList() << QString::fromLatin1("foo"); }
void returnError(const QDBusMessage &msg) const
{
msg.setDelayedReply(true);
QDBusConnection::sessionBus().send(msg.createErrorReply("dbuspendingcall_error", ""));
}
};
class tst_QDBusPendingCall: public QObject
{
Q_OBJECT
public:
tst_QDBusPendingCall();
public Q_SLOTS:
void callback(const QStringList &list);
void errorCallback(const QDBusError &error);
void finished(QDBusPendingCallWatcher *call);
void makeCall();
private Q_SLOTS:
void initTestCase();
void waitForFinished();
void waitForFinished_error();
void watcher();
void watcher_error();
void watcher_waitForFinished();
void watcher_waitForFinished_threaded();
void watcher_waitForFinished_alreadyFinished();
void watcher_waitForFinished_alreadyFinished_eventLoop();
void watcher_waitForFinished_error();
void callInsideWaitForFinished();
void callWithCallback_localLoop();
void callWithCallback_localLoop_errorReply();
private:
QDBusPendingCall sendMessage();
QDBusPendingCall sendError();
QDBusConnection conn;
enum { CallbackCalled, ErrorCallbackCalled, FinishCalled, MakeCallCalled };
int slotCalled;
int callCount;
QStringList callbackArgument;
QDBusError errorArgument;
QDBusPendingCallWatcher *watchArgument;
MyObject *obj;
};
tst_QDBusPendingCall::tst_QDBusPendingCall()
: conn(QDBusConnection::sessionBus())
, obj(new MyObject(this))
{
}
void tst_QDBusPendingCall::finished(QDBusPendingCallWatcher *call)
{
slotCalled = FinishCalled;
++callCount;
watchArgument = call;
if (QThread::currentThread() == thread())
QTestEventLoop::instance().exitLoop();
}
void tst_QDBusPendingCall::callback(const QStringList &list)
{
slotCalled = CallbackCalled;
++callCount;
callbackArgument = list;
QTestEventLoop::instance().exitLoop();
}
void tst_QDBusPendingCall::errorCallback(const QDBusError &error)
{
slotCalled = ErrorCallbackCalled;
++callCount;
errorArgument = error;
QTestEventLoop::instance().exitLoop();
}
void tst_QDBusPendingCall::makeCall()
{
// make an external call to D-Bus to make sure we haven't left any locks
slotCalled = MakeCallCalled;
++callCount;
sendMessage().waitForFinished();
}
void tst_QDBusPendingCall::initTestCase()
{
QVERIFY(conn.isConnected());
QVERIFY(conn.registerObject("/", this));
}
QDBusPendingCall tst_QDBusPendingCall::sendMessage()
{
QDBusMessage msg = QDBusMessage::createMethodCall("org.freedesktop.DBus",
"/",
"org.freedesktop.DBus",
"ListNames");
return conn.asyncCall(msg);
}
QDBusPendingCall tst_QDBusPendingCall::sendError()
{
QDBusMessage msg = QDBusMessage::createMethodCall("org.freedesktop.DBus",
"/",
"org.freedesktop.DBus",
"ThisNameWontExist");
return conn.asyncCall(msg);
}
void tst_QDBusPendingCall::waitForFinished()
{
QDBusPendingCall ac = sendMessage();
ac.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
const QDBusMessage reply = ac.reply();
QCOMPARE(reply.type(), QDBusMessage::ReplyMessage);
QCOMPARE(reply.signature(), QString("as"));
const QVariantList args = ac.reply().arguments();
QCOMPARE(args.size(), 1);
const QVariant &arg = args.at(0);
QCOMPARE(arg.userType(), QMetaType::QStringList);
QVERIFY(arg.toStringList().contains(conn.baseService()));
}
void tst_QDBusPendingCall::waitForFinished_error()
{
QDBusPendingCall ac = sendError();
ac.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(ac.isError());
QDBusError error = ac.error();
QVERIFY(error.isValid());
QCOMPARE(error.name(), QString("org.freedesktop.DBus.Error.UnknownMethod"));
QCOMPARE(error.type(), QDBusError::UnknownMethod);
}
void tst_QDBusPendingCall::callWithCallback_localLoop()
{
// Verify that a callback actually gets called when the call is dispatched locally.
QDBusInterface iface(QDBusConnection::sessionBus().baseService(), QLatin1String("/"),
TEST_INTERFACE_NAME);
QVERIFY(iface.isValid());
QVERIFY(iface.callWithCallback("returnFoo", QVariantList(), this, SLOT(callback(QStringList))));
// May be called synchronously or asynchronously...
if (callbackArgument != (QStringList() << QString::fromLatin1("foo"))) {
QTestEventLoop::instance().enterLoop(2);
QVERIFY(!QTestEventLoop::instance().timeout());
}
QCOMPARE(callbackArgument, QStringList() << QString::fromLatin1("foo"));
}
void tst_QDBusPendingCall::callWithCallback_localLoop_errorReply()
{
// Verify that an error callback actually gets called when the call is
// dispatched locally and the called method returns an error
QDBusInterface iface(QDBusConnection::sessionBus().baseService(), QLatin1String("/"),
TEST_INTERFACE_NAME);
QVERIFY(iface.isValid());
callbackArgument.clear();
QVERIFY(iface.callWithCallback("returnError", QVariantList(), this,
SLOT(callback(QStringList)), SLOT(errorCallback(QDBusError))));
// May be called synchronously or asynchronously...
if (errorArgument.name() != "dbuspendingcall_error") {
QTestEventLoop::instance().enterLoop(2);
QVERIFY(!QTestEventLoop::instance().timeout());
}
QCOMPARE(errorArgument.name(), QString::fromLatin1("dbuspendingcall_error"));
QVERIFY(callbackArgument.isEmpty());
}
void tst_QDBusPendingCall::watcher()
{
QDBusPendingCall ac = sendMessage();
callCount = 0;
watchArgument = 0;
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
QTestEventLoop::instance().enterLoop(2);
QVERIFY(!QTestEventLoop::instance().timeout());
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(conn.baseService()));
}
void tst_QDBusPendingCall::watcher_error()
{
QDBusPendingCall ac = sendError();
callCount = 0;
watchArgument = 0;
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
QTestEventLoop::instance().enterLoop(2);
QVERIFY(!QTestEventLoop::instance().timeout());
QVERIFY(ac.isFinished());
QVERIFY(ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(watch.isError());
QVERIFY(watch.error().isValid());
}
void tst_QDBusPendingCall::watcher_waitForFinished()
{
QDBusPendingCall ac = sendMessage();
callCount = 0;
watchArgument = 0;
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
watch.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(conn.baseService()));
}
void tst_QDBusPendingCall::watcher_waitForFinished_threaded()
{
callCount = 0;
watchArgument = 0;
slotCalled = 0;
class WorkerThread: public QThread {
public:
tst_QDBusPendingCall *tst;
WorkerThread(tst_QDBusPendingCall *tst) : tst(tst) {}
void run() override
{
QDBusPendingCall ac = tst->sendMessage();
// QVERIFY(!ac.isFinished());
// QVERIFY(!ac.isError());
// QCOMPARE(ac.reply().type(), QDBusMessage::InvalidMessage);
QDBusPendingCallWatcher watch(ac);
tst->connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)), Qt::DirectConnection);
QTest::qSleep(100); // don't process events in this thread
// QVERIFY(!ac.isFinished());
// QVERIFY(!ac.isError());
// QCOMPARE(ac.reply().type(), QDBusMessage::InvalidMessage);
QCOMPARE(tst->callCount, 0);
QCOMPARE(tst->slotCalled, 0);
watch.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
QCOMPARE(tst->callCount, 1);
QCOMPARE(tst->slotCalled, (int)FinishCalled);
QCOMPARE(tst->watchArgument, &watch);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(tst->conn.baseService()));
}
} thread(this);
QTestEventLoop::instance().connect(&thread, SIGNAL(finished()), SLOT(exitLoop()));
thread.start();
QTestEventLoop::instance().enterLoop(10);
QVERIFY(thread.wait(3000));
QVERIFY(!QTestEventLoop::instance().timeout());
}
void tst_QDBusPendingCall::watcher_waitForFinished_alreadyFinished()
{
QDBusPendingCall ac = sendMessage();
ac.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
callCount = 0;
watchArgument = 0;
// create a watcher on an already-finished reply
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
watch.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(conn.baseService()));
}
void tst_QDBusPendingCall::watcher_waitForFinished_alreadyFinished_eventLoop()
{
QDBusPendingCall ac = sendMessage();
ac.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
callCount = 0;
watchArgument = 0;
// create a watcher on an already-finished reply
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
&QTestEventLoop::instance(), SLOT(exitLoop()));
QTestEventLoop::instance().enterLoop(1);
QVERIFY(!QTestEventLoop::instance().timeout());
QVERIFY(ac.isFinished());
QVERIFY(!ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(conn.baseService()));
}
void tst_QDBusPendingCall::watcher_waitForFinished_error()
{
QDBusPendingCall ac = sendError();
callCount = 0;
watchArgument = 0;
QDBusPendingCallWatcher watch(ac);
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(finished(QDBusPendingCallWatcher*)));
watch.waitForFinished();
QVERIFY(ac.isFinished());
QVERIFY(ac.isError());
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)FinishCalled);
QCOMPARE(watchArgument, &watch);
QVERIFY(watch.isError());
QVERIFY(watch.error().isValid());
}
void tst_QDBusPendingCall::callInsideWaitForFinished()
{
QDBusPendingCall ac = sendMessage();
QDBusPendingCallWatcher watch(ac);
callCount = 0;
connect(&watch, SIGNAL(finished(QDBusPendingCallWatcher*)),
SLOT(makeCall()));
watch.waitForFinished();
QCOMPARE(callCount, 1);
QCOMPARE(slotCalled, (int)MakeCallCalled);
QVERIFY(!watch.isError());
const QVariantList args2 = ac.reply().arguments();
QVERIFY(!args2.isEmpty());
QVERIFY(args2.at(0).toStringList().contains(conn.baseService()));
}
QTEST_MAIN(tst_QDBusPendingCall)
#include "tst_qdbuspendingcall.moc"
Reference in New Issue View Git Blame Copy Permalink