AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5152c3ca82
qt5base-lts/tests
History
Marc Mutz 626a4d89c2 QFormLayout: take the correct row in takeRow() 
I didn't even try to understand what the old code was trying to do;
once you're told by a user that the code is wrong, you see that it is.

Fixed by just using the row as passed to takeRow() instead of trying
to do some storage-index calculations. The m_matrix indexing operator
does it all for us.

Added a test that checks that the expected field widget gets
returned. Fixed expected test data that was wrong, and just checking
that the implementation behaves as implemented, instead of as
documented.

Amends change 8fbae648db.

[ChangeLog][QtWidget][QFormLayout] The functions takeRow() and
removeRow(), new in 5.8.0, now take and remove the correct row.

Task-number: QTBUG-58693
Task-number: QTBUG-15990
Change-Id: I7185ccbc6c03e2579741cad5c0c821d3ed165474
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2017-02-08 11:01:31 +00:00
..
auto QFormLayout: take the correct row in takeRow() 2017-02-08 11:01:31 +00:00
baselineserver Merge remote-tracking branch 'origin/5.7' into dev 2016-05-23 21:09:46 +02:00
benchmarks QtGui/painting benchmark test: Fix Clang warning about uninitialized value 2017-01-31 08:37:56 +00:00
global
manual manual tests: Fix build with modularized configure.json 2016-12-14 16:49:34 +00:00
shared Windows CE cleanup. 2016-04-14 12:45:56 +00:00
README
tests.pro Use qtConfig throughout in qtbase 2016-08-19 04:28:05 +00:00

README 

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.