qt5base-lts/tests/auto/network
Thiago Macieira 674e79416f Fix incomplete override of QIODevice::open in QProcess and QLocalSocket
The rule for a new override is that it must still work if the old
implementation is called. The catch is that any class that derives from
QProcess and isn't recompiled will still have QIODevice::open in its
virtual table. That is equivalent to overriding open() and calling
QIODevice::open() (like the tests).

In Qt 5.0, QProcess::start() called QIODevice::open directly, not the
virtual open(), so there's no expectation that a user-overridden open()
be called. With that in mind, simply fix QProcess::start to not call the
virtual open at all.

Similarly with QLocalSocket, the calls to open were always non-virtual.

Task-number: QTBUG-32284
Change-Id: I88925f0ba08bc23c849658b54582744997e69a4c
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
2013-07-20 00:22:03 +02:00
..
access test: Mark tst_QNetworkReply::backgroundRequestInterruption() as XFAIL on OS X 10.8 2013-07-15 16:21:15 +02:00
bearer Whitespace cleanup: remove trailing whitespace 2013-03-16 20:22:50 +01:00
kernel Further followup to Q_OS_MACX changes. 2013-06-24 15:49:31 +02:00
socket Fix incomplete override of QIODevice::open in QProcess and QLocalSocket 2013-07-20 00:22:03 +02:00
ssl SSL internals: do not write after shutting down the socket 2013-04-23 23:22:43 +02:00
network.pro Re-enable network tests on Mac OS. 2012-04-24 16:06:28 +02:00