2f33e030b8
- Replaced the usages of deprecated APIs by corresponding
alternatives in the library code and documentation.
- Modified the tests to make them build when deprecated APIs disabled:
* Made the the parts of the tests testing the deprecated APIs to
be compiled conditionally, only when the corresponding methods are
enabled.
* If the test-case tests only the deprecated API, but not the
corresponding replacement, added tests for the replacement.
Change-Id: Ic38245015377fc0c8127eb5458c184ffd4b450f1
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
126 lines
4.1 KiB
C++
126 lines
4.1 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of the test suite of the Qt Toolkit.
|
|
**
|
|
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
** $QT_END_LICENSE$
|
|
**
|
|
****************************************************************************/
|
|
|
|
|
|
#include <QtTest/QtTest>
|
|
#include <qdebug.h>
|
|
#include <qdesktopservices.h>
|
|
#include <qregularexpression.h>
|
|
|
|
class tst_qdesktopservices : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void openUrl();
|
|
void handlers();
|
|
#if QT_DEPRECATED_SINCE(5, 0)
|
|
void testDataLocation();
|
|
#endif
|
|
};
|
|
|
|
void tst_qdesktopservices::openUrl()
|
|
{
|
|
// At the bare minimum check that they return false for invalid url's
|
|
QCOMPARE(QDesktopServices::openUrl(QUrl()), false);
|
|
#if defined(Q_OS_WIN) && !defined(Q_OS_WINRT)
|
|
// this test is only valid on windows on other systems it might mean open a new document in the application handling .file
|
|
const QRegularExpression messagePattern("ShellExecute 'file://invalid\\.file' failed \\(error \\d+\\)\\.");
|
|
QVERIFY(messagePattern.isValid());
|
|
QTest::ignoreMessage(QtWarningMsg, messagePattern);
|
|
QCOMPARE(QDesktopServices::openUrl(QUrl("file://invalid.file")), false);
|
|
#endif
|
|
}
|
|
|
|
class MyUrlHandler : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
QUrl lastHandledUrl;
|
|
|
|
public slots:
|
|
inline void handle(const QUrl &url) {
|
|
lastHandledUrl = url;
|
|
}
|
|
};
|
|
|
|
void tst_qdesktopservices::handlers()
|
|
{
|
|
MyUrlHandler fooHandler;
|
|
MyUrlHandler barHandler;
|
|
|
|
QDesktopServices::setUrlHandler(QString("foo"), &fooHandler, "handle");
|
|
QDesktopServices::setUrlHandler(QString("bar"), &barHandler, "handle");
|
|
|
|
QUrl fooUrl("foo://blub/meh");
|
|
QUrl barUrl("bar://hmm/hmmmm");
|
|
|
|
QVERIFY(QDesktopServices::openUrl(fooUrl));
|
|
QVERIFY(QDesktopServices::openUrl(barUrl));
|
|
|
|
QCOMPARE(fooHandler.lastHandledUrl.toString(), fooUrl.toString());
|
|
QCOMPARE(barHandler.lastHandledUrl.toString(), barUrl.toString());
|
|
}
|
|
|
|
#if defined(Q_OS_UNIX) && !defined(Q_OS_MAC)
|
|
#define Q_XDG_PLATFORM
|
|
#endif
|
|
|
|
#if QT_DEPRECATED_SINCE(5, 0)
|
|
void tst_qdesktopservices::testDataLocation()
|
|
{
|
|
// This is the one point where QDesktopServices and QStandardPaths differ.
|
|
// QDesktopServices on unix returns "data"/orgname/appname for DataLocation, for Qt4 compat.
|
|
// And the appname in qt4 defaulted to empty, not to argv[0].
|
|
{
|
|
const QString base = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation);
|
|
const QString app = QDesktopServices::storageLocation(QDesktopServices::DataLocation);
|
|
#ifdef Q_XDG_PLATFORM
|
|
QCOMPARE(app, base + "/data//"); // as ugly as in Qt4
|
|
#else
|
|
QCOMPARE(app, base);
|
|
#endif
|
|
}
|
|
QCoreApplication::instance()->setOrganizationName("Qt");
|
|
QCoreApplication::instance()->setApplicationName("QtTest");
|
|
{
|
|
const QString base = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation);
|
|
const QString app = QDesktopServices::storageLocation(QDesktopServices::DataLocation);
|
|
#ifdef Q_XDG_PLATFORM
|
|
QCOMPARE(app, base + "/data/Qt/QtTest");
|
|
#else
|
|
QCOMPARE(app, base + "/Qt/QtTest");
|
|
#endif
|
|
}
|
|
}
|
|
#endif
|
|
|
|
QTEST_MAIN(tst_qdesktopservices)
|
|
|
|
#include "tst_qdesktopservices.moc"
|