Go to file
Marc Mutz 8b771e782d QNetworkReply: replace a QQueue with a std::vector
The 'queue' was never used as a queue: it was populated, and then
exchanged into a local copy to be consumed in a loop. This loop used
dequeue(), but of course it could just const-iterate the container and
dump it as the end, since the member variable was already reset at
that point, no-one could tell the difference from the outside.

So, no need for a queue. A vector will do very nicely.

The loop now uses ranged-for and qExchange(), greatly simplifying the
code over the old version.

Add another qExchange() call as a drive-by.

Change-Id: I6147453dc9edfe9500833627b123bb3a31114651
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2019-05-15 09:00:10 +00:00
bin syncqt: Fix resolution of injected headers for external modules 2019-04-23 09:09:33 +00:00
config.tests x86: Disable AVX support on 64-bit MinGW 2019-02-06 08:11:29 +00:00
dist Merge remote-tracking branch 'origin/5.12' into 5.13 2019-04-24 01:00:13 +02:00
doc Merge remote-tracking branch 'origin/5.12' into 5.13 2019-05-09 13:06:11 +00:00
examples Merge remote-tracking branch 'origin/5.13' into dev 2019-05-15 07:11:41 +02:00
lib
mkspecs Merge remote-tracking branch 'origin/5.13' into dev 2019-05-15 07:11:41 +02:00
qmake Merge remote-tracking branch 'origin/5.13' into dev 2019-05-15 07:11:41 +02:00
src QNetworkReply: replace a QQueue with a std::vector 2019-05-15 09:00:10 +00:00
tests QFtp: Skip the flaky QTestEventLoop::timeout in Coin network 2019-05-15 06:10:13 +00:00
util Merge remote-tracking branch 'origin/5.13' into dev 2019-05-13 08:04:58 +02:00
.gitattributes
.gitignore Remove support for qml1 plugins and modules 2018-11-15 19:52:13 +00:00
.qmake.conf Bump version 2019-03-22 05:35:40 +00:00
.tag
config_help.txt Merge remote-tracking branch 'origin/5.13' into dev 2019-05-07 11:58:30 +02:00
configure
configure.bat Configure: simplify logic 2019-03-14 12:13:58 +00:00
configure.json Add qmake support for c++2a 2019-04-19 08:14:25 +00:00
configure.pri Add qmake support for c++2a 2019-04-19 08:14:25 +00:00
header.BSD
header.COMM
header.FDL
header.GPL
header.GPL-EXCEPT
header.LGPL
header.LGPL3
header.LGPL3-COMM
header.LGPL-NOGPL2
header.LGPL-ONLY
header.MIT
INSTALL INSTALL: Remove outdated reference to Windows CE 2019-02-13 13:01:57 +00:00
LICENSE.FDL
LICENSE.GPL2
LICENSE.GPL3
LICENSE.GPL3-EXCEPT
LICENSE.LGPL3
LICENSE.LGPLv3
LICENSE.QT-LICENSE-AGREEMENT-4.0
qtbase.pro
sync.profile platformsupport/input: add xkbcommon utilities lib 2019-03-01 14:31:28 +00:00