AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
27,780 Commits 4 Branches 0 Tags 339 MiB
C++ 84.2%
HTML 5.1%
C 4.2%
CMake 2.9%
Objective-C++ 2%
Other 1%
8d8991c697
Go to file
Marc Mutz 8d8991c697 QXbmHandler: don't construct a QByteArray just to find '0x' in text 
Even QByteArray::fromRawData() allocates memory.

Instead of QByteArray::contains() and indexOf(), use good ol'
strstr(), like already done elsewhere in the same function.

Apart from the memory allocations saved, this fixes a Coverity error
complaining that indexOf() can return -1. It's a false positive on the
first occurrence, because we didn't call that function unless we know
there is a "0x" in the string, but the second _was_ wrong, because we
applied it on a new buffer, with unknown content.

Coverity-Id: 11262
Change-Id: I18f352c5576e24f89a5c3ef7f2f1b2176f2a235d
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
2016-11-16 19:49:04 +00:00
bin syncqt.pl: fix a few misguided regexes to match .h file names 2016-09-28 04:56:56 +00:00
config.tests Enable GL prototypes with recent Khronos headers 2016-11-10 12:16:20 +00:00
dist add buildsystem changelog for 5.6.2 2016-09-25 06:42:29 +00:00
doc Doc: CSS: Add styling for content generated with \legalese command 2016-10-28 13:02:22 +00:00
examples Update bookmarks in the XML bookmarks examples 2016-11-01 08:37:50 +00:00
lib Initial import from the monolithic Qt. 2011-04-27 12:05:43 +02:00
mkspecs qmake: fix installation of asset catalog files 2016-11-14 15:48:41 +00:00
qmake don't create bogus property variants 2016-11-14 12:19:05 +00:00
src QXbmHandler: don't construct a QByteArray just to find '0x' in text 2016-11-16 19:49:04 +00:00
tests Stabilize tst_QFileDialog2::task143519_deleteAndRenameActionBehavior() 2016-11-15 09:56:31 +00:00
tools configure: Determine MSVC version by evaluating macro _MSC_FULL_VER 2016-10-27 12:03:22 +00:00
util Don't use QStringLiteral in comparisons 2016-01-28 18:00:47 +00:00
.gitattributes Update the git-archive export options 2012-09-07 15:39:31 +02:00
.gitignore Update gitignore 2016-08-19 10:43:26 +00:00
.qmake.conf Bump version 2016-05-23 18:28:33 +00:00
.tag Update the git-archive export options 2012-09-07 15:39:31 +02:00
configure fix wording issues in license prompt 2016-11-14 12:19:14 +00:00
configure.bat Move the official Qt version from qglobal.h to .qmake.conf 2015-10-14 20:12:57 +00:00
header.BSD Updated BSD licensed file headers 2015-02-15 07:41:17 +00:00
header.COMM Add header template for commercial only modules 2015-10-19 10:37:18 +00:00
header.FDL Update copyright headers 2015-02-11 06:49:51 +00:00
header.LGPL3 Update copyright headers 2015-02-11 06:49:51 +00:00
header.LGPL3-COMM Update copyright headers 2015-02-11 06:49:51 +00:00
header.LGPL21 Update copyright headers 2015-02-11 06:49:51 +00:00
header.LGPL-ONLY Update copyright headers 2015-02-11 06:49:51 +00:00
INSTALL Doc: Update links in INSTALL file 2015-02-16 09:06:41 +00:00
LGPL_EXCEPTION.txt Update copyright headers 2015-02-11 06:49:51 +00:00
LICENSE.FDL Initial import from the monolithic Qt. 2011-04-27 12:05:43 +02:00
LICENSE.GPLv3 Expand license scope from "Qt GUI Toolkit" to "Qt Toolkit" 2016-06-15 07:02:32 +00:00
LICENSE.LGPLv3 Expand license scope from "Qt GUI Toolkit" to "Qt Toolkit" 2016-06-15 07:02:32 +00:00
LICENSE.LGPLv21 Expand license scope from "Qt GUI Toolkit" to "Qt Toolkit" 2016-06-15 07:02:32 +00:00
LICENSE.PREVIEW.COMMERCIAL Update copyright headers 2015-02-11 06:49:51 +00:00
qtbase.pro copy global qdoc config files in non-prefix shadow builds 2016-09-29 13:44:20 +00:00
sync.profile remove dependencies from sync.profile 2016-11-05 21:04:25 +00:00